From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD3DB-0004Qs-Gx for qemu-devel@nongnu.org; Thu, 31 Jul 2014 23:08:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XD3D7-0005D0-3i for qemu-devel@nongnu.org; Thu, 31 Jul 2014 23:08:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD3D6-0005CR-Mw for qemu-devel@nongnu.org; Thu, 31 Jul 2014 23:08:49 -0400 Message-ID: <53DB0499.2010505@redhat.com> Date: Thu, 31 Jul 2014 21:08:09 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406860365-5516-1-git-send-email-arei.gonglei@huawei.com> <1406860365-5516-3-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1406860365-5516-3-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c1mtaRbxnT057uw9q7dhxTTx0Eck5RKCl" Subject: Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, weidong.huang@huawei.com, stefanha@redhat.com, mst@redhat.com, marcel.a@redhat.com, luonengjun@huawei.com, armbru@redhat.com, lcapitulino@redhat.com, av1474@comtv.ru, kraxel@redhat.com, aliguori@amazon.com, imammedo@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, peter.huangpeng@huawei.com, afaerber@suse.de, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c1mtaRbxnT057uw9q7dhxTTx0Eck5RKCl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2014 08:32 PM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Signed-off-by: Gonglei > --- > hw/usb/dev-audio.c | 2 +- > hw/usb/dev-mtp.c | 4 ++-- > hw/usb/hcd-ehci.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/usb/dev-audio.c b/hw/usb/dev-audio.c > index bfebfe9..988f6cc 100644 > --- a/hw/usb/dev-audio.c > +++ b/hw/usb/dev-audio.c > @@ -371,7 +371,7 @@ static void output_callback(void *opaque, int avail= ) > return; > } > data =3D streambuf_get(&s->out.buf); > - if (NULL =3D=3D data) { > + if (data =3D=3D NULL) { Wouldn't it be even more idiomatic as: if (!data) { Probably applies throughout your series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --c1mtaRbxnT057uw9q7dhxTTx0Eck5RKCl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT2wSZAAoJEKeha0olJ0NqGS8IAKkso5TIeZSqSfkIZ2px1Txl o5JI+baOEVz2VWKxiPz/OYpaGTeg2ua7HuOmyfjfHP+nk+TujfJDSNBy+fQYYAok N5qtkDSKaSuyOidkpWmGG6Ac0aHZXMkyb/gH4r0Mdg9561QCOMe4J+8+LV3XiPio ZcZFJ9vkX9jelnNMFwrqeMnN8zLAWLetlpLaHw8LpvuKomkWpEAwFTBHWTLURe7+ iMU8id3Z1BGKAty0vKArOpn9k6MJ24h9bArlmATTEfv++qvvpI9nDXXk6WVzyObY aMa0b0U99BkfdSH17ZNnCyOd2PCGEw+5kCbsPRrJNkATOvyy5/gxqgZh739G6Xc= =a+67 -----END PGP SIGNATURE----- --c1mtaRbxnT057uw9q7dhxTTx0Eck5RKCl--