From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD74E-0002dK-Ee for qemu-devel@nongnu.org; Fri, 01 Aug 2014 03:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XD745-0008WH-AH for qemu-devel@nongnu.org; Fri, 01 Aug 2014 03:15:54 -0400 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]:37723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XD744-0008WD-Mu for qemu-devel@nongnu.org; Fri, 01 Aug 2014 03:15:44 -0400 Received: by mail-qg0-f43.google.com with SMTP id a108so5443144qge.30 for ; Fri, 01 Aug 2014 00:15:44 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53DB3E9B.7000805@redhat.com> Date: Fri, 01 Aug 2014 09:15:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1404757089-4836-1-git-send-email-jsnow@redhat.com> <1404757089-4836-16-git-send-email-jsnow@redhat.com> <20140731122336.GR25929@stefanha-thinkpad.redhat.com> In-Reply-To: <20140731122336.GR25929@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/28] ide: stop PIO transfer on errors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , John Snow Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com Il 31/07/2014 14:23, Stefan Hajnoczi ha scritto: > On Mon, Jul 07, 2014 at 02:17:56PM -0400, John Snow wrote: >> From: Paolo Bonzini >> >> This will provide a hook for sending the result of the command via the >> FIS receive area. >> >> Signed-off-by: Paolo Bonzini >> Signed-off-by: John Snow >> --- >> hw/ide/core.c | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/hw/ide/core.c b/hw/ide/core.c >> index bd3bd34..d900ba0 100644 >> --- a/hw/ide/core.c >> +++ b/hw/ide/core.c >> @@ -422,6 +422,9 @@ static inline void ide_abort_command(IDEState *s) >> { >> s->status = READY_STAT | ERR_STAT; >> s->error = ABRT_ERR; >> + if (s->end_transfer_func != ide_transfer_stop) { >> + ide_transfer_stop(s); >> + } >> } > > I don't understand this. > > ide_transfer_stop() sets s->send_transfer_func = ide_transfer_stop. > This has the side-effect of making ide_is_pio_out() return true (not > sure if that poses a problem). ide_is_pio_out is only called if DRQ_STAT is set, and it is never set after ide_transfer_stop returns, so that is not a problem. > Why can't we call ide_transfer_stop() when s->end_transfer_func == > ide_transfer_stop? The idea was to only call it for PIO commands (if s->end_transfer_func == ide_transfer_stop, the PIO command cannot fail anymore), but we might as well call it unconditionally like ide_dma_error does, i.e. { + ide_transfer_stop(s); s->status = READY_STAT | ERR_STAT; s->error = ABRT_ERR; } It's simpler indeed. Paolo