From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Joel Schopp <joel.schopp@amd.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest
Date: Fri, 01 Aug 2014 13:41:40 +0200 [thread overview]
Message-ID: <53DB7CF4.1020702@redhat.com> (raw)
In-Reply-To: <CAFEAcA_t12TF3xeEtA4N7cwN5gsCx_Cpk9N5CJ13m_UN6n0y2A@mail.gmail.com>
Il 01/08/2014 13:28, Peter Maydell ha scritto:
> Paolo: can you review this? Do we also need to do something
> about the use of TARGET_PAGE_BITS in
> kvm_physical_sync_dirty_bitmap?
No, it should be the host page size, matching
cpu_physical_memory_set_dirty_lebitmap.
> Is it really OK to define
> PAGE_SIZE to TARGET_PAGE_SIZE (it's certainly really
> misleading and suggests the kernel headers could be more
> helpful).
No, it's wrong.
> Basically I think kvm-all.c should almost certainly not be
> using any of the TARGET_PAGE_* constants anywhere.
I agree.
I think the patch is right but, besides these considerations, does this
bug still manifest itself after Andrew fixed the start address of the
device at 0x90010000 (IIRC it was the pl031)?
Paolo
next prev parent reply other threads:[~2014-08-01 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-23 20:09 [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest Joel Schopp
2014-08-01 11:28 ` Peter Maydell
2014-08-01 11:41 ` Paolo Bonzini [this message]
2014-08-01 14:02 ` Joel Schopp
2014-08-01 14:19 ` Paolo Bonzini
2014-08-01 18:36 ` Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB7CF4.1020702@redhat.com \
--to=pbonzini@redhat.com \
--cc=joel.schopp@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).