From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XDCFr-0008Av-EU
	for qemu-devel@nongnu.org; Fri, 01 Aug 2014 08:48:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XDCFl-0000ge-9x
	for qemu-devel@nongnu.org; Fri, 01 Aug 2014 08:48:15 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31352)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XDBDY-00043R-BB
	for qemu-devel@nongnu.org; Fri, 01 Aug 2014 07:41:48 -0400
Message-ID: <53DB7CF4.1020702@redhat.com>
Date: Fri, 01 Aug 2014 13:41:40 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20140723200925.9787.75225.stgit@joelaarch64.amd.com>
	<CAFEAcA_t12TF3xeEtA4N7cwN5gsCx_Cpk9N5CJ13m_UN6n0y2A@mail.gmail.com>
In-Reply-To: <CAFEAcA_t12TF3xeEtA4N7cwN5gsCx_Cpk9N5CJ13m_UN6n0y2A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] arm64: 64K pages and > 1024MB guest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Joel Schopp <joel.schopp@amd.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Il 01/08/2014 13:28, Peter Maydell ha scritto:
> Paolo: can you review this? Do we also need to do something
> about the use of TARGET_PAGE_BITS in
> kvm_physical_sync_dirty_bitmap?

No, it should be the host page size, matching
cpu_physical_memory_set_dirty_lebitmap.

> Is it really OK to define
> PAGE_SIZE to TARGET_PAGE_SIZE (it's certainly really
> misleading and suggests the kernel headers could be more
> helpful).

No, it's wrong.

> Basically I think kvm-all.c should almost certainly not be
> using any of the TARGET_PAGE_* constants anywhere.

I agree.

I think the patch is right but, besides these considerations, does this
bug still manifest itself after Andrew fixed the start address of the
device at 0x90010000 (IIRC it was the pl031)?

Paolo