From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEdAg-0004Cj-Bh for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:44:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEdAX-0007vp-0H for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:44:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEdAW-0007vj-Ot for qemu-devel@nongnu.org; Tue, 05 Aug 2014 07:44:40 -0400 Message-ID: <53E0C39E.7020503@redhat.com> Date: Tue, 05 Aug 2014 13:44:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1407209598-2572-1-git-send-email-ming.lei@canonical.com> <20140805094844.GF4391@noname.str.redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 00/17] dataplane: optimization and multi virtqueue support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ming Lei , Kevin Wolf Cc: Peter Maydell , Fam Zheng , qemu-devel , Stefan Hajnoczi , "Michael S. Tsirkin" Il 05/08/2014 12:00, Ming Lei ha scritto: >> > >> > I also think that the device emulation has no business in deciding >> > whether the bypass is used (it depends solely on conditions outside of >> > the device) and that leaking the fd number out of raw-posix is wrong. >> > Both of them are layering violations that shouldn't be reintroduced. > Yes, that is right, and I have added comments that the bypass hint will > be moved to block layer completely in future. Actually, it will never be accepted in the first place. We have told you repeatedly that the bypass as you wrote it is buggy and a layering violation. Paolo