From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEe2Q-0007gS-U2 for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:40:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEe2M-0000l1-CY for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:40:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6829) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEe2L-0000kr-US for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:40:18 -0400 Message-ID: <53E0D0AC.3080406@redhat.com> Date: Tue, 05 Aug 2014 06:40:12 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406870842-17988-1-git-send-email-benoit.canet@irqsave.net> <1406870842-17988-2-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1406870842-17988-2-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XAfJ2RBNDrOvL9SGfj2wfxQUngKAk3Www" Subject: Re: [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XAfJ2RBNDrOvL9SGfj2wfxQUngKAk3Www Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2014 11:26 PM, Beno=C3=AEt Canet wrote: > This patch will allow to link qmp.o with utility binaries without dragg= ing too s/allow to link/allow linking/ > much unrelated object files and externals dependencies. s/dragging too much/dragging in too many/ s/externals/external/ >=20 > Signed-off-by: Benoit Canet > --- > Makefile.objs | 2 +- > qmp-system.c | 376 ++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qmp.c | 361 +-------------------------------------------------= ----- > 3 files changed, 379 insertions(+), 360 deletions(-) > create mode 100644 qmp-system.c >=20 When reviewing code motion, I like to do: $ diff -u <(sed -n 's/^-//p' patch) <(sed -n 's/^+//p' patch) In the case of this patch, you rearranged functions, which makes it MUCH harder to see if everything moved correctly (for example, the old code has qmp_query_kvm, qmp_query_uuid, qmp_quit, qmp_stop...; the new code has them in a different order). It would be a lot easier if you create the new file with the function order preserved as it was in the original file. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XAfJ2RBNDrOvL9SGfj2wfxQUngKAk3Www Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4NCsAAoJEKeha0olJ0NqMdUH/1bPmbF7iMO0DxDwyGlhdoZ1 xab4OyYTiu50+PmpkGr5vmlJEJUoRpjvQaWnT1ReROuyKw3MwtRRrzf5vP+NEppT YBfdT3jPOGBGxA1rUriuXBWrqMRtsUQ9UQqe/1wRma3NHyXFzaTgpKHjgNYlNWp/ pGvfet/vwoSmv7KMnxDBwi4jyZmHtG3hYIWGW33VzE0Epe3JOPQPRyjRRgtD372t NAI1e+QFaksdan5UMMJ1dAfUzrTrNrVkDX+vhGBn+QM2Nu/OSua72F3i+tqVv/sf uNmzBdMFQ4+uWz2pl0lZX6YiDzwaD8X64UEO2JtPEjiUpfiP3+OD+wP4hyhbzSw= =Vyvt -----END PGP SIGNATURE----- --XAfJ2RBNDrOvL9SGfj2wfxQUngKAk3Www--