From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@irqsave.net>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Benoit Canet <benoit@irqsave.net>,
stefanha@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1 03/24] monitor: Extract monitor-system.h header
Date: Tue, 05 Aug 2014 06:47:41 -0600 [thread overview]
Message-ID: <53E0D26D.7090503@redhat.com> (raw)
In-Reply-To: <1406870842-17988-4-git-send-email-benoit.canet@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]
On 07/31/2014 11:27 PM, Benoît Canet wrote:
> This header will allow to split monitor in two parts.
s/allow to split monitor in/allow splitting the monitor into/
>
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
> include/monitor/monitor-system.h | 99 ++++++++++++++++++++++++++++++++++++++++
> monitor.c | 57 ++---------------------
> 2 files changed, 102 insertions(+), 54 deletions(-)
> create mode 100644 include/monitor/monitor-system.h
>
> +struct Monitor {
> + CharDriverState *chr;
> + int reset_seen;
Should we be converting this field to bool at some point in the series?
(Probably as a separate patch, since this patch is more focused on code
motion).
> +
> +typedef struct mon_cmd_t {
This isn't typical qemu naming convention. Can we fix that up in this
series? (Probably best as a separate patch before this one)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-05 12:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 5:26 [Qemu-devel] [PATCH v1 00/24] Extract qmp.c and monitor.c core and wire QMP into qemu-nbd Benoît Canet
2014-08-01 5:26 ` [Qemu-devel] [PATCH v1 01/24] qmp: Extract system emulation related code from qmp.c into qmp-system.c Benoît Canet
2014-08-05 12:40 ` Eric Blake
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 02/24] monitor: Make some function public Benoît Canet
2014-08-05 12:41 ` Eric Blake
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 03/24] monitor: Extract monitor-system.h header Benoît Canet
2014-08-05 12:47 ` Eric Blake [this message]
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 04/24] monitor: Make monitor_fprintf public before extracting it Benoît Canet
2014-08-05 12:48 ` Eric Blake
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 05/24] monitor: Extract monitor_fprintf to monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 06/24] monitor: Extract qmp_human_monitor_command into monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 07/24] monitor: Make some function to extract public Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 08/24] monitor: Extract a couple of function to monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 09/24] monitor: Make do_info_help public Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 10/24] monitor: Extract do_info_help in monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 11/24] monitor: Make some monitor functions public before moving them " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 12/24] monitor: Make do_loadvm public before moving it to monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 13/24] monitor: Move do_loadvm from monitor.c " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 14/24] monitor: Make commands public before moving them " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 15/24] monitor: Move mon_cmd_t arrays and some function from monitor.c " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 16/24] monitor: Move more functions " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 17/24] monitor: Move two net " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 18/24] monitor: Move qmp_rtc_reset_reinjection " Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 19/24] monitor-system: Switch back functions to static Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 20/24] monitor: Extract hardware dependent completion function from monitor.c to monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 21/24] monitor: Cleanup monitor.c includes after extracting monitor-system.c Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 22/24] qemu-nbd: build QAPI block core into qemu-nbd Benoît Canet
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 23/24] qapi: Add a script to filter qmp-commands-old.h to generate a subset of it Benoît Canet
2014-08-05 12:51 ` Eric Blake
2014-08-01 5:27 ` [Qemu-devel] [PATCH v1 24/24] qemu-nbd: Add --qmp option to qemu-nbd Benoît Canet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0D26D.7090503@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=benoit@irqsave.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).