From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51365) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEe9d-0007Jh-Vc for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:47:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEe9Z-000377-FR for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:47:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEe9Z-00036p-6W for qemu-devel@nongnu.org; Tue, 05 Aug 2014 08:47:45 -0400 Message-ID: <53E0D26D.7090503@redhat.com> Date: Tue, 05 Aug 2014 06:47:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406870842-17988-1-git-send-email-benoit.canet@irqsave.net> <1406870842-17988-4-git-send-email-benoit.canet@irqsave.net> In-Reply-To: <1406870842-17988-4-git-send-email-benoit.canet@irqsave.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bisvWcdqAMPPTKJPNUj4teQCxQa8r3CtS" Subject: Re: [Qemu-devel] [PATCH v1 03/24] monitor: Extract monitor-system.h header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Benoit Canet , stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bisvWcdqAMPPTKJPNUj4teQCxQa8r3CtS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2014 11:27 PM, Beno=C3=AEt Canet wrote: > This header will allow to split monitor in two parts. s/allow to split monitor in/allow splitting the monitor into/ >=20 > Signed-off-by: Benoit Canet > --- > include/monitor/monitor-system.h | 99 ++++++++++++++++++++++++++++++++= ++++++++ > monitor.c | 57 ++--------------------- > 2 files changed, 102 insertions(+), 54 deletions(-) > create mode 100644 include/monitor/monitor-system.h >=20 > +struct Monitor { > + CharDriverState *chr; > + int reset_seen; Should we be converting this field to bool at some point in the series? (Probably as a separate patch, since this patch is more focused on code motion). > + > +typedef struct mon_cmd_t { This isn't typical qemu naming convention. Can we fix that up in this series? (Probably best as a separate patch before this one) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bisvWcdqAMPPTKJPNUj4teQCxQa8r3CtS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4NJtAAoJEKeha0olJ0NqTmsH/11obXRZef+9Ts6EzoO499IY pOu83mD0OEmZqXigjCZhmTvosBFweZWgfvyMtnArm2Xw818l93afTA7/Ya8YM1CZ 92sWA8nwAMpvo2M2R+v4fY0BgF2H3xyGvU0QPYhtRqSqMK9pmNIlodFOWdtBhKg+ rzm1U394mdoS4LjZRaSvT/RW8SIR0OjRUKRFoTxt4DOUMbAE0KhcHWMdTaUg7FlV jEUwhNYjC7dX0RG4rLBPD+0dBK3Gw6RTuVccLOdKqMu4z+C0gCJfrKmtATUBBKcC Y6OLCnY3DNPJgsvgkkX8cXEInK+r3HVHvG355VMwjZp9qOD77DobBA+p7HPY+Bs= =X5tv -----END PGP SIGNATURE----- --bisvWcdqAMPPTKJPNUj4teQCxQa8r3CtS--