From: Laszlo Ersek <lersek@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH] acpi: align RSDP
Date: Tue, 05 Aug 2014 17:25:53 +0200 [thread overview]
Message-ID: <53E0F781.2070100@redhat.com> (raw)
In-Reply-To: <1407164351-18544-1-git-send-email-mst@redhat.com>
On 08/04/14 17:40, Michael S. Tsirkin wrote:
> RSDP should be aligned at a 16-byte boundary.
> This would by chance at the moment, fix up acpi build
> to make it robust.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 816c6d9..10b84d0 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1393,7 +1393,7 @@ build_rsdp(GArray *rsdp_table, GArray *linker, unsigned rsdt)
> {
> AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
>
> - bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 1,
> + bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 16,
> true /* fseg memory */);
>
> memcpy(&rsdp->signature, "RSD PTR ", 8);
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
prev parent reply other threads:[~2014-08-05 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 15:40 [Qemu-devel] [PATCH] acpi: align RSDP Michael S. Tsirkin
2014-08-05 15:25 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E0F781.2070100@redhat.com \
--to=lersek@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).