* [Qemu-devel] [PATCH] acpi: align RSDP
@ 2014-08-04 15:40 Michael S. Tsirkin
2014-08-05 15:25 ` Laszlo Ersek
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2014-08-04 15:40 UTC (permalink / raw)
To: qemu-devel; +Cc: imammedo, lersek
RSDP should be aligned at a 16-byte boundary.
This would by chance at the moment, fix up acpi build
to make it robust.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 816c6d9..10b84d0 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1393,7 +1393,7 @@ build_rsdp(GArray *rsdp_table, GArray *linker, unsigned rsdt)
{
AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
- bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 1,
+ bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 16,
true /* fseg memory */);
memcpy(&rsdp->signature, "RSD PTR ", 8);
--
MST
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] acpi: align RSDP
2014-08-04 15:40 [Qemu-devel] [PATCH] acpi: align RSDP Michael S. Tsirkin
@ 2014-08-05 15:25 ` Laszlo Ersek
0 siblings, 0 replies; 2+ messages in thread
From: Laszlo Ersek @ 2014-08-05 15:25 UTC (permalink / raw)
To: Michael S. Tsirkin, qemu-devel; +Cc: imammedo
On 08/04/14 17:40, Michael S. Tsirkin wrote:
> RSDP should be aligned at a 16-byte boundary.
> This would by chance at the moment, fix up acpi build
> to make it robust.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/i386/acpi-build.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 816c6d9..10b84d0 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1393,7 +1393,7 @@ build_rsdp(GArray *rsdp_table, GArray *linker, unsigned rsdt)
> {
> AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp);
>
> - bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 1,
> + bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 16,
> true /* fseg memory */);
>
> memcpy(&rsdp->signature, "RSD PTR ", 8);
>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-05 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-04 15:40 [Qemu-devel] [PATCH] acpi: align RSDP Michael S. Tsirkin
2014-08-05 15:25 ` Laszlo Ersek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).