From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33832) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEgcl-0004Jm-3d for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:26:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEgce-00017T-VM for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:26:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5014) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEgce-00017H-NU for qemu-devel@nongnu.org; Tue, 05 Aug 2014 11:25:56 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s75FPtEh011458 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 5 Aug 2014 11:25:55 -0400 Message-ID: <53E0F781.2070100@redhat.com> Date: Tue, 05 Aug 2014 17:25:53 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1407164351-18544-1-git-send-email-mst@redhat.com> In-Reply-To: <1407164351-18544-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] acpi: align RSDP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: imammedo@redhat.com On 08/04/14 17:40, Michael S. Tsirkin wrote: > RSDP should be aligned at a 16-byte boundary. > This would by chance at the moment, fix up acpi build > to make it robust. > > Signed-off-by: Michael S. Tsirkin > --- > hw/i386/acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 816c6d9..10b84d0 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -1393,7 +1393,7 @@ build_rsdp(GArray *rsdp_table, GArray *linker, unsigned rsdt) > { > AcpiRsdpDescriptor *rsdp = acpi_data_push(rsdp_table, sizeof *rsdp); > > - bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 1, > + bios_linker_loader_alloc(linker, ACPI_BUILD_RSDP_FILE, 16, > true /* fseg memory */); > > memcpy(&rsdp->signature, "RSD PTR ", 8); > Reviewed-by: Laszlo Ersek