From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEuYH-0007WH-2c for qemu-devel@nongnu.org; Wed, 06 Aug 2014 02:18:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XEuYA-0006kj-IL for qemu-devel@nongnu.org; Wed, 06 Aug 2014 02:18:21 -0400 Received: from mga03.intel.com ([143.182.124.21]:51310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XEuYA-0006jg-DN for qemu-devel@nongnu.org; Wed, 06 Aug 2014 02:18:14 -0400 Message-ID: <53E1C8A2.6080507@intel.com> Date: Wed, 06 Aug 2014 14:18:10 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1406808574-19728-1-git-send-email-tiejun.chen@intel.com> <1406808574-19728-2-git-send-email-tiejun.chen@intel.com> <20140804134800.GA17674@redhat.com> In-Reply-To: <20140804134800.GA17674@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v3][PATCH 1/4] i440fx: make types configurable at run-time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com On 2014/8/4 21:48, Michael S. Tsirkin wrote: > On Thu, Jul 31, 2014 at 08:09:31PM +0800, Tiejun Chen wrote: >> Xen wants to supply a different pci and host devices, >> inheriting i440fx devices. Make types configurable. >> >> Signed-off-by: Michael S. Tsirkin >> Signed-off-by: Tiejun Chen > > You should have a From: line too, otherwise > git will set the Author field incorrectly. > Will update as follows: From: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen Thanks Tiejun