From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread
Date: Wed, 06 Aug 2014 10:45:15 +0200 [thread overview]
Message-ID: <53E1EB1B.4040304@redhat.com> (raw)
In-Reply-To: <1407303308-4615-10-git-send-email-famz@redhat.com>
Il 06/08/2014 07:35, Fam Zheng ha scritto:
> ifeq ($(CONFIG_VIRTIO),y)
> -obj-y += virtio-scsi.o
> +obj-y += virtio-scsi.o virtio-scsi-dataplane.o
> obj-$(CONFIG_VHOST_SCSI) += vhost-scsi.o
> endif
I first thought that this must be conditional on
CONFIG_VIRTIO_BLK_DATA_PLANE. However, CONFIG_VIRTIO_BLK_DATA_PLANE is
itself obsolete:
##########################################
# adjust virtio-blk-data-plane based on linux-aio
if test "$virtio_blk_data_plane" = "yes" -a \
"$linux_aio" != "yes" ; then
error_exit "virtio-blk-data-plane requires Linux AIO, please try --enable-linux-aio"
elif test -z "$virtio_blk_data_plane" ; then
virtio_blk_data_plane=$linux_aio
fi
and there's no requirement to have Linux AIO anymore. Can you prepare a
patch to drop CONFIG_VIRTIO_BLK_DATA_PLANE, and replace patch 1 with it?
We can leave --disable-virtio-blk-data-plane and --enable-virtio-blk-data-plane
in for a couple of releases.
Paolo
next prev parent reply other threads:[~2014-08-06 8:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 5:34 [Qemu-devel] [RFC PATCH v2 00/10] virtio-scsi: Dataplane on single iothread Fam Zheng
2014-08-06 5:34 ` [Qemu-devel] [RFC PATCH v2 01/10] virtio: Compile vring code unconditionally Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 02/10] virtio-scsi: Split virtio_scsi_handle_cmd_req from virtio_scsi_handle_cmd Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 03/10] virtio-scsi: Split virtio_scsi_handle_ctrl_req from virtio_scsi_handle_ctrl Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 04/10] virtio-scsi: Add VirtIOSCSIVring in VirtIOSCSIReq Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 05/10] virtio-scsi: Make virtio_scsi_init_req public Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 06/10] virtio-scsi: Make virtio_scsi_free_req public Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 07/10] virtio-scsi: Make virtio_scsi_push_event public Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 08/10] virtio-scsi: Add 'iothread' property to virtio-scsi-pci Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code to run virtio-scsi on iothread Fam Zheng
2014-08-06 8:45 ` Paolo Bonzini [this message]
2014-08-06 9:07 ` Fam Zheng
2014-09-19 9:29 ` Paolo Bonzini
2014-09-22 5:56 ` Fam Zheng
2014-09-22 8:09 ` Paolo Bonzini
2014-09-22 8:33 ` Fam Zheng
2014-09-22 6:14 ` Fam Zheng
2014-08-06 5:35 ` [Qemu-devel] [RFC PATCH v2 10/10] virtio-scsi: Hook up with dataplane Fam Zheng
2014-09-19 9:30 ` Paolo Bonzini
2014-09-19 9:28 ` [Qemu-devel] [RFC PATCH v2 00/10] virtio-scsi: Dataplane on single iothread Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E1EB1B.4040304@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).