From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF8uf-00044v-5F for qemu-devel@nongnu.org; Wed, 06 Aug 2014 17:38:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XF8ua-0002pa-MP for qemu-devel@nongnu.org; Wed, 06 Aug 2014 17:38:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF8ua-0002pU-D7 for qemu-devel@nongnu.org; Wed, 06 Aug 2014 17:38:20 -0400 Message-ID: <53E2A03C.1020701@redhat.com> Date: Wed, 06 Aug 2014 15:38:04 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kSwMEkB9g5P0TD6odDIOWohNics26w1gr" Subject: Re: [Qemu-devel] [PATCH 0/7] target-i386: x87 exception pointers using TCG. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SmF1bWUgTWFydMOt?= , qemu-devel@nongnu.org, "riku.voipio" , mtosatti@redhat.com, pbonzini@redhat.com, afaerber@suse.de, mst , gleb@redhat.com, "alex.bennee" , anthony , quintela@redhat.com, vrozenfe@redhat.com, Peter Maydell , Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kSwMEkB9g5P0TD6odDIOWohNics26w1gr Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/06/2014 02:46 PM, Jaume Mart=C3=AD wrote: > Hello, >=20 > I submit a patch to fix bugs 661696 and 1248376. > I already submitted a previous version of this patch, this version requ= ires > less TCG operations to execute. If this is a second version of the patch, then you should have v2 in the subject line ('git send-email -v2' is your friend). > As mentioned in a previous email, the patch implements, for TCG, the > specifications provided in Intel and AMD programmer's manuals regarding= the > x87 exception pointers. That is, when executing instructions > fstenv/fnstenv, fsave and fxsave the values for the instruction pointer= , > data pointer and opcode of the last non-control x87 instruction execute= d, > are correctly saved to the specified memory address. When executing > instructions fldenv, frstor and fxrstor the values that are going to be= > considered the instruction pointer, data pointer and opcode of the last= > non-control x87 instruction are obtained from the specified memory addr= ess. >=20 > I divided this patch in 8 parts, this first part involves changes in th= e > CPUX86State struct to store the exception pointers. Huh? This mail is titled 0/7, so I only expect 7 parts. Oh... >=20 > Best regards, > Jaume >=20 > Signed-off-by: Jaume Marti Farriol (jaume.martif@gmail.com) > diff --git a/target-i386/cpu.h b/target-i386/cpu.h > index e634d83..4274ce3 100644 > --- a/target-i386/cpu.h > +++ b/target-i386/cpu.h =2E..reviewers don't expect to see patch contents in the cover letter. I= f you truly have eight parts, then they should be numbered 1/8 through 8/8, and this cover letter 0/8 should contain only a diffstat summary of those 8 patches. Furthermore, your threading appears to be wrong - your remaining patches each start their own thread instead of being in reply to this cover letter. Please make sure you set In-Reply-To headers correctly when sending a series. http://wiki.qemu.org/Contribute/SubmitAPatch has more hints on how to send a patch series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kSwMEkB9g5P0TD6odDIOWohNics26w1gr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4qA9AAoJEKeha0olJ0NqCb8H+wXcwA2wiJjlN/H8LC9Wz13Z kn88+y7yOHFCP3guGUEoVgI6bOJyKjzM+PAdvRt3XAqMR6Il0AWKaRO3p2YsNRBH XKxLY2QIBXLNuf+2ue2bq2cow695rwDLAqTTaK26kR/rNX2SFf8PlTuQnh6xUnZ5 1LED8YQ31HRtRTp882v8BCMPlqFmMZ01kYC5YUMgyeeF5jhMlwCenX3BNZ64MsAN ugav3Y+wJlx3vDb5FxcIwrH7IzWn9ikd51mZuVAWp+68f4J59ySDFJCiBorheYva QbE8oR2nHlHtAuBz8nAwWi52y5M6Rgk6XGzQ10j7XMKfi5HZ7cWGt2SaOPBBs0I= =Fble -----END PGP SIGNATURE----- --kSwMEkB9g5P0TD6odDIOWohNics26w1gr--