Re: [Qemu-devel] [PATCH v2 4/4] ivshmem: check the value returned by fstat()

[zhanghailiang <zhang.zhanghailiang@huawei.com>]

On 2014/8/6 20:30, Levente Kurusa wrote:
>> The function fstat() may fail, so check its return value.
>>
>> Signed-off-by: zhanghailiang<zhang.zhanghailiang@huawei.com>
>> ---
>>   hw/misc/ivshmem.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
>> index 768e528..5d939d2 100644
>> --- a/hw/misc/ivshmem.c
>> +++ b/hw/misc/ivshmem.c
>> @@ -324,7 +324,11 @@ static int check_shm_size(IVShmemState *s, int fd) {
>>
>>       struct stat buf;
>>
>> -    fstat(fd,&buf);
>> +    if (fstat(fd,&buf)<  0) {
>> +        fprintf(stderr, "ivshmem: exiting for fstat fd '%d' failed: %s\n",
>> +                fd, strerror(errno));
>
> exiting for fstat?
>
> I would go with something like this:
>
> "ivshmem: exiting: fstat on fd %d failed: %s"
>
> ... or something among the lines.

Hmmm, this is more clear, i will change it.Thanks!