From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53719)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XFKmi-0006bX-3w
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 06:19:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XFKmc-0004rH-0X
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 06:19:00 -0400
Received: from mx1.redhat.com ([209.132.183.28]:18824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XFKmb-0004r3-Pa
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 06:18:53 -0400
Message-ID: <53E35287.1070608@redhat.com>
Date: Thu, 07 Aug 2014 12:18:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1407349101-27793-1-git-send-email-ehabkost@redhat.com>
	<1407349101-27793-2-git-send-email-ehabkost@redhat.com>
	<20140807022412.GB8109@z.redhat.com>
In-Reply-To: <20140807022412.GB8109@z.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RESEND 1/2] rng-egd: Free old chr_name
 value before setting new one
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Markus Armbruster <armbru@redhat.com>

Il 07/08/2014 04:24, Amos Kong ha scritto:
> Eduardo, a similar patch had been applied.
> 
> commit 5e490b6a504912225dff0e520e1c6af68295d238
> Author: Amos Kong <akong@redhat.com>
> Date:   Thu Nov 21 16:42:50 2013 +0800
> 
>     rng-egd: remove redundant free
>     
>     We didn't set default chr_name, the free is redundant.
>     
>     Signed-off-by: Amos Kong <akong@redhat.com>
>     Message-id: 1385023371-8198-2-git-send-email-akong@redhat.com
>     Signed-off-by: Anthony Liguori <aliguori@amazon.com>
> 

What if you set chr_name twice?

Paolo