From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1XFN0Q-0004NP-Rt
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 08:41:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1XFN0L-0008Db-UE
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 08:41:18 -0400
Received: from relay.parallels.com ([195.214.232.42]:32981)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <den@openvz.org>) id 1XFN0L-0007ku-Cm
	for qemu-devel@nongnu.org; Thu, 07 Aug 2014 08:41:13 -0400
Message-ID: <53E37414.50502@openvz.org>
Date: Thu, 7 Aug 2014 16:41:56 +0400
From: "Denis V. Lunev" <den@openvz.org>
MIME-Version: 1.0
References: <1406564635-261591-1-git-send-email-den@openvz.org>
In-Reply-To: <1406564635-261591-1-git-send-email-den@openvz.org>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/4] block/parallels: 2TB+ parallels
	images support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On 28/07/14 20:23, Denis V. Lunev wrote:
> Parallels has released in the recent updates of Parallels Server 5/6
> new addition to his image format. Images with signature WithouFreSpacExt
> have offsets in the catalog coded not as offsets in sectors (multiple
> of 512 bytes) but offsets coded in blocks (i.e. header->tracks * 512)
>
> In this case to code the virtual disk size for such images nb_sectors
> field is extended to 64 bits. The reader of older images with signature
> WithoutFreeSpace must manually zero most valuable bits of nb_sectors
> on open.
>
> Changes from v1:
> - fixed message in patch 1
> - added braces to conform qemu coding style in patches 3 & 4
> - added check for ph.tracks in patch 4 to avoid offset overflow as suggested
>    by Jeff
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Jeff Cody <jcody@redhat.com>
can you pls look/commit. I have some other changes on top of this