From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFPxr-0003PD-D7 for qemu-devel@nongnu.org; Thu, 07 Aug 2014 11:50:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFPxm-0007L2-El for qemu-devel@nongnu.org; Thu, 07 Aug 2014 11:50:51 -0400 Message-ID: <53E3A051.6030707@redhat.com> Date: Thu, 07 Aug 2014 09:50:41 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407357598-21541-1-git-send-email-mdroth@linux.vnet.ibm.com> <53E2A2FE.1060401@redhat.com> <20140807091908.6230.28961@loki> In-Reply-To: <20140807091908.6230.28961@loki> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GdInjaELi40SAVgX41s6L2fqpph14SAhc" Subject: Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GdInjaELi40SAVgX41s6L2fqpph14SAhc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2014 03:19 AM, Michael Roth wrote: >> >> Libvirt could support active commit against qemu 2.0.1 if you backport= >> these patches: >> >> Jeff Cody >> 7676e2c597 block: make 'top' argument to block-commit optional >> >> Fam Zheng >> 9e48b02540 mirror: Go through ready -> complete process for 0 len im= age >=20 > Actually ended up needing the following with a few fix-ups: >=20 > 7676e2c->98103fa block: make 'top' argument to block-commit optional > 8b9a30c->e5f0eb0 qemu-iotests: Test BLOCK_JOB_READY event for 0Kb image= active commit > 9e48b02->43ac708 mirror: Go through ready -> complete process for 0 len= image > dc71ce4->8e09e20 blockjob: Add block_job_yield() > 373df5b->520b341 mirror: Fix resource leak when bdrv_getlength fails >=20 > I've gone ahead and pushed them, but please test as we generally don't > do features (even backward-compatible ones) for stable, and this wasn't= > as trivial as I was hoping. Yes, I'll test and report back. However, I don't think this is a feature addition, so much as a bug fix for an existing feature (all the hard work for active commit was already in 2.0, all that was missing was a way for libvirt to introspect that it existed, and some corner case bugs with 0-length images). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GdInjaELi40SAVgX41s6L2fqpph14SAhc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT46BRAAoJEKeha0olJ0NqRHQIAIyz/f6BSBx8tvVv1Y4WfLgH XB/RF4j18F/UnKxDiRcmiXcHGJkAXehAObMQpDSBrmR8i0gXGrzHEcPcwz1F+Kmp vNRQYksqJZF+NSEAC572d78foW8YRvPjP3vT53nZk4C0DEIH5c5U7MricbBH5Us3 LAOEKjuv5LaqteKt/JFOWCeaiVoFeCHXc98XTQeZoxnsnEK4U09D4RvDsPXRDv1f mXlYRTt1yvCh4OuoK/IcXIpFVw0wwsUMHOqczJ49v8zhj0x5SsQ1J6hRvo6Pt5pU 51YXuL9kgclKBJKrv0JJlrNhg6fQMFEUoLVWsPocuFV7f5ESjrKujo2ygHfzMwA= =fqqg -----END PGP SIGNATURE----- --GdInjaELi40SAVgX41s6L2fqpph14SAhc--