From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFUmD-0002gP-7v for qemu-devel@nongnu.org; Thu, 07 Aug 2014 16:59:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFUm7-0001Ci-Ct for qemu-devel@nongnu.org; Thu, 07 Aug 2014 16:59:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFUm7-0001Cc-5L for qemu-devel@nongnu.org; Thu, 07 Aug 2014 16:59:03 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s77Kx2KR025097 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 7 Aug 2014 16:59:02 -0400 Message-ID: <53E3E895.3050606@redhat.com> Date: Thu, 07 Aug 2014 14:59:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407444475-19516-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1407444475-19516-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EXXkQ4Fo6mhtmcUtabL604DvOEidD9CF8" Subject: Re: [Qemu-devel] [PATCH 0/3] qcow2: Prevent corruption-related crashes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EXXkQ4Fo6mhtmcUtabL604DvOEidD9CF8 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2014 02:47 PM, Max Reitz wrote: > The first two patches in this series address > https://bugs.launchpad.net/qemu/+bug/1349972. >=20 > For the third patch I found it hard to write an appropriate test case > (it would have to make qemu-img check repair some leaks but induce the > corruption prevention at the same time). One can use the test image fro= m > the bug report above, set the refcount block offset to 0 and that works= =2E > However, the patch is simple enough that no test should be necessary. Series: Reviewed-by: Eric Blake >=20 >=20 > Max Reitz (3): > qcow2: Catch !*host_offset for data allocation > iotests: Add test for image header overlap > block: Catch !bs->drv in bdrv_check() >=20 > block.c | 3 +++ > block/qcow2-cluster.c | 11 +++++++++++ > tests/qemu-iotests/060 | 9 +++++++++ > tests/qemu-iotests/060.out | 8 ++++++++ > 4 files changed, 31 insertions(+) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EXXkQ4Fo6mhtmcUtabL604DvOEidD9CF8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4+iVAAoJEKeha0olJ0NqrpUIAKyxGWyMO8hpVPefRpqy0PwV tJFjdsy2LyDUH3nmhNxOtTNLxed0SEkqcHyiSBMCF+fYvG2s+Mj3XjB0QI4AfNgb RytRqRik9WR5iG2Q+lPZCFVzvWs1k+cjffs5CwXCJIkeQPwoX/c1rj8+uohGu0L7 LJxXpN8N6EgQ4Yf0JaFOFCMzkAC6ta9UyVZHKM9QHGlq/2/r4YPkiHNpZLzB95Uv JfOOAcOiRVJKiWQ0UWYnNCOfKPG1rWyIcZhd76Hb6eJQXVU7iVgiseBiGjsnQcFQ BBUvAH8WnhCfmJ1q2HrN4to3gVrUwrKM1UR4ywKA2Wjvr9KlTwElFeputiou2kc= =9es2 -----END PGP SIGNATURE----- --EXXkQ4Fo6mhtmcUtabL604DvOEidD9CF8--