From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFVlj-0006J2-LA for qemu-devel@nongnu.org; Thu, 07 Aug 2014 18:02:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFVle-0004J0-OB for qemu-devel@nongnu.org; Thu, 07 Aug 2014 18:02:43 -0400 Message-ID: <53E3F77A.2020807@redhat.com> Date: Thu, 07 Aug 2014 16:02:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407357598-21541-1-git-send-email-mdroth@linux.vnet.ibm.com> <53E2A2FE.1060401@redhat.com> <20140807091908.6230.28961@loki> <53E3A051.6030707@redhat.com> In-Reply-To: <53E3A051.6030707@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KXtQKujViInxKu88qK6acRsFFSHAF4Ovl" Subject: Re: [Qemu-devel] [000/108] Patch Round-up for stable 2.0.1, freeze on 2014-08-12 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KXtQKujViInxKu88qK6acRsFFSHAF4Ovl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/07/2014 09:50 AM, Eric Blake wrote: > On 08/07/2014 03:19 AM, Michael Roth wrote: >>> >>> Libvirt could support active commit against qemu 2.0.1 if you backpor= t >>> these patches: >>> >>> Jeff Cody >>> 7676e2c597 block: make 'top' argument to block-commit optional >>> >>> Fam Zheng >>> 9e48b02540 mirror: Go through ready -> complete process for 0 len i= mage >> >> Actually ended up needing the following with a few fix-ups: >> >> 7676e2c->98103fa block: make 'top' argument to block-commit optional >> 8b9a30c->e5f0eb0 qemu-iotests: Test BLOCK_JOB_READY event for 0Kb imag= e active commit >> 9e48b02->43ac708 mirror: Go through ready -> complete process for 0 le= n image >> dc71ce4->8e09e20 blockjob: Add block_job_yield() >> 373df5b->520b341 mirror: Fix resource leak when bdrv_getlength fails >> >> I've gone ahead and pushed them, but please test as we generally don't= >> do features (even backward-compatible ones) for stable, and this wasn'= t >> as trivial as I was hoping. >=20 > Yes, I'll test and report back. Testing complete - without the patches (commit e0efb023 on your branch), libvirt 1.2.7 failed to run an active commit, even though I could run one by hand via QMP; with the patches (commit 98103fa7 on your branch) libvirt detected active commit and managed it just fine. I've replied separately with a couple more patches (one that I needed for getting a build made for running my tests, another for a coredump in drive-mirror that I triggered while setting up my active commit tests). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KXtQKujViInxKu88qK6acRsFFSHAF4Ovl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT4/d6AAoJEKeha0olJ0NqezYH/RSLzWSOgQHGLYpIWe2L6VoK yMJ2KV9chZxA+0Fdzm53gtc1560qULZrNAq8PYAOWWnDjnYpV+pqIouj12h/MBjm N1xFdZYLAMl3z2iQDjf5l1uMuUjUL4zL7ehUEQ6tH9E+K62JPRg600R0FGnlicmq 5S1PxXOCPfVgPa8ZelcJU51zVEwwZwAjsh5lQni4bVK00wfqi0fY/Hmd9JVIzjRo yXde9Ym9hrUaqrQ2SKlX88IynvZbLuqSspTEYDU75sxYZghEu4iI35+0X2RG8Cll 4bxtyH7jzkY/T6UHt7q2BQB1bZYnuxUbt/QXG2xe2gEzIHsE319yKQZlvqtl/34= =ivG/ -----END PGP SIGNATURE----- --KXtQKujViInxKu88qK6acRsFFSHAF4Ovl--