From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFje3-0000DJ-SF for qemu-devel@nongnu.org; Fri, 08 Aug 2014 08:51:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFjdz-00020C-DT for qemu-devel@nongnu.org; Fri, 08 Aug 2014 08:51:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFjdz-000207-4e for qemu-devel@nongnu.org; Fri, 08 Aug 2014 08:51:39 -0400 Message-ID: <53E4C7D6.3050900@redhat.com> Date: Fri, 08 Aug 2014 06:51:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1404830964-10733-1-git-send-email-fromani@redhat.com> <1404830964-10733-2-git-send-email-fromani@redhat.com> <20140801113940.GC7258@stefanha-thinkpad.redhat.com> <20140805084757.GB4391@noname.str.redhat.com> <20140805130846.GA12251@stefanha-thinkpad.redhat.com> <1841263794.17835817.1407484879020.JavaMail.zimbra@redhat.com> In-Reply-To: <1841263794.17835817.1407484879020.JavaMail.zimbra@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="abVCkIQui4Vnr6VrP1Ac4H5sHR8kAi9xf" Subject: Re: [Qemu-devel] [PATCH] block: add watermark event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Francesco Romani , Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --abVCkIQui4Vnr6VrP1Ac4H5sHR8kAi9xf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/08/2014 02:01 AM, Francesco Romani wrote: >>>> So let the block-set-watermark caller pass an absolute sector number= >>>> instead. It keeps things simple for both QEMU and thin provisioning= >>>> manager. >>> >>> No sector numbers in external interfaces, please. These units of 512 >>> bytes are completely arbitrary and don't make any sense. I hope to ge= t >>> rid of BDRV_SECTOR_* eventually even internally. >>> >>> So for external APIs, please use bytes instead. >> >> I agree and forgot about that. Please use bytes instead of sectors or= a >> percentage. >> >=20 > Thanks everyone for the great feedback received! >=20 > I'll post asap a new patch addressing all the comments. >=20 > I'll also change the name because 'watermark' may be misleading/wrong j= argon :) > (http://en.wikipedia.org/wiki/Watermark) Is "threshold" a better name than "watermark"? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --abVCkIQui4Vnr6VrP1Ac4H5sHR8kAi9xf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT5MfWAAoJEKeha0olJ0NqwcAIAJel9G/YHRa59QnU2WTdjXjA /UxBcBLoVGr8KWPqJcQL4qiQ6YZjO+iO5ix2NGr3uYQ+IyA6fKttvRmr0vI2KlCH 34LKPJaJwxdmEqj1Z8DkKoq42UKjdOLkc4uxw9MkJJAqaIp9m2+LzrsqPelbrGjO QZEtvCbhnvU774bPcWH7m8WoEKUPNQn+99lFrGFqESXrtwReEIiMpbKYp6qFSeqv vzoK6WEFRyEFno9SdBLY7aJSuzApfuglHPzqCYDz5/npMWBKHt35v2evXdW7K9YD kfEwCooAqH90FbhZYA0ZeNaA5WQlkI1nGl4/rWijoWUiltCFCYpCBh2DXG1XqrU= =DyVG -----END PGP SIGNATURE----- --abVCkIQui4Vnr6VrP1Ac4H5sHR8kAi9xf--