From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGnx4-0000dO-JX for qemu-devel@nongnu.org; Mon, 11 Aug 2014 07:39:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGnwy-0000vw-BY for qemu-devel@nongnu.org; Mon, 11 Aug 2014 07:39:46 -0400 Message-ID: <53E8AB7A.70203@suse.de> Date: Mon, 11 Aug 2014 13:39:38 +0200 From: Alexander Graf MIME-Version: 1.0 References: <1406799254-25223-1-git-send-email-aik@ozlabs.ru> <1406799254-25223-4-git-send-email-aik@ozlabs.ru> In-Reply-To: <1406799254-25223-4-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 03/10] spapr_pci: Make find_phb()/find_dev() public List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Alex Williamson , qemu-ppc@nongnu.org On 31.07.14 11:34, Alexey Kardashevskiy wrote: > This makes find_phb()/find_dev() public and changed its names > to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to > be used from other parts of QEMU such as VFIO DDW (dynamic DMA window) > or VFIO PCI error injection or VFIO EEH handling - in all these > cases there are RTAS calls which are addressed to BUID+config_addr > in IEEE1275 format. > > Signed-off-by: Alexey Kardashevskiy Is there any particular reason these RTAS calls can't get handled inside of spapr_pci.c? After all, if they work on PCI granularity, they are semantically bound to the PCI PHB emulation. Alex