From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGoLN-0005iv-UD for qemu-devel@nongnu.org; Mon, 11 Aug 2014 08:04:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGoLI-0002Uy-1l for qemu-devel@nongnu.org; Mon, 11 Aug 2014 08:04:53 -0400 Received: from mail-wg0-f42.google.com ([74.125.82.42]:45181) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGoLH-0002Uo-RW for qemu-devel@nongnu.org; Mon, 11 Aug 2014 08:04:47 -0400 Received: by mail-wg0-f42.google.com with SMTP id l18so8375732wgh.25 for ; Mon, 11 Aug 2014 05:04:47 -0700 (PDT) Message-ID: <53E8B15A.6080703@linaro.org> Date: Mon, 11 Aug 2014 14:04:42 +0200 From: Eric Auger MIME-Version: 1.0 References: <1407594349-9291-1-git-send-email-eric.auger@linaro.org> <1407594349-9291-9-git-send-email-eric.auger@linaro.org> <53E88EC4.9040803@suse.de> In-Reply-To: <53E88EC4.9040803@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 08/10] hw/intc/arm_gic_kvm: advertise irqfd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com Cc: peter.maydell@linaro.org, patches@linaro.org, joel.schopp@amd.com, will.deacon@arm.com, stuart.yoder@freescale.com, Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu On 08/11/2014 11:37 AM, Alexander Graf wrote: > > On 09.08.14 16:25, Eric Auger wrote: >> set kvm_irqfds_allowed >> >> Signed-off-by: Eric Auger >> --- >> hw/intc/arm_gic_kvm.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/intc/arm_gic_kvm.c b/hw/intc/arm_gic_kvm.c >> index 5038885..08b7bf9 100644 >> --- a/hw/intc/arm_gic_kvm.c >> +++ b/hw/intc/arm_gic_kvm.c >> @@ -576,6 +576,8 @@ static void kvm_arm_gic_realize(DeviceState *dev, >> Error **errp) >> KVM_DEV_ARM_VGIC_GRP_ADDR, >> KVM_VGIC_V2_ADDR_TYPE_CPU, >> s->dev_fd); >> + >> + kvm_irqfds_allowed = true; > > Is this always true? If it is, why not enable it separately while making > vhost-net work for example? Hi Alex, yes I think so. As soon as KVM is enabled, KVM/arm would enable injection though irqfd. Defintively makes sense to test it with vhost-net too. Well a matter of priority ;-) Best Regards Eric > > Alex >