From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47840) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGpVH-0006pw-SP for qemu-devel@nongnu.org; Mon, 11 Aug 2014 09:19:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGpVB-0000eM-0u for qemu-devel@nongnu.org; Mon, 11 Aug 2014 09:19:11 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGpVA-0000eC-Rc for qemu-devel@nongnu.org; Mon, 11 Aug 2014 09:19:04 -0400 Received: by mail-wi0-f169.google.com with SMTP id n3so5518153wiv.4 for ; Mon, 11 Aug 2014 06:19:04 -0700 (PDT) Message-ID: <53E8C2C3.4050401@linaro.org> Date: Mon, 11 Aug 2014 15:18:59 +0200 From: Eric Auger MIME-Version: 1.0 References: <1407510229-28167-1-git-send-email-eric.auger@linaro.org> <1407510229-28167-6-git-send-email-eric.auger@linaro.org> <53E8C0C9.3080500@suse.de> In-Reply-To: <53E8C0C9.3080500@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC v2 5/7] hw/arm/boot: load_dtb becomes non static List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , eric.auger@st.com, christoffer.dall@linaro.org, qemu-devel@nongnu.org, kim.phillips@freescale.com, a.rigo@virtualopensystems.com Cc: peter.maydell@linaro.org, patches@linaro.org, will.deacon@arm.com, stuart.yoder@freescale.com, Bharat.Bhushan@freescale.com, alex.williamson@redhat.com, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu On 08/11/2014 03:10 PM, Alexander Graf wrote: > > On 08.08.14 17:03, Eric Auger wrote: >> load_dtb will be used by machvirt for dynamic instantiation of >> platform devices >> >> Signed-off-by: Eric Auger >> --- >> hw/arm/boot.c | 2 +- >> include/hw/arm/arm.h | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/hw/arm/boot.c b/hw/arm/boot.c >> index 1241761..53b43e8 100644 >> --- a/hw/arm/boot.c >> +++ b/hw/arm/boot.c >> @@ -312,7 +312,7 @@ static void set_kernel_args_old(const struct >> arm_boot_info *info) >> } >> } >> -static int load_dtb(hwaddr addr, const struct arm_boot_info *binfo) >> +int load_dtb(hwaddr addr, const struct arm_boot_info *binfo) > > Please rename it arm_load_dtb then. OK thanks Eric > > > Alex > >> { >> void *fdt = NULL; >> int size, rc; >> diff --git a/include/hw/arm/arm.h b/include/hw/arm/arm.h >> index cbbf4ca..fe58dc0 100644 >> --- a/include/hw/arm/arm.h >> +++ b/include/hw/arm/arm.h >> @@ -68,6 +68,7 @@ struct arm_boot_info { >> hwaddr entry; >> }; >> void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info); >> +int load_dtb(hwaddr addr, const struct arm_boot_info *binfo); >> /* Multiplication factor to convert from system clock ticks to >> qemu timer >> ticks. */ >