From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGsZB-0004nd-3v for qemu-devel@nongnu.org; Mon, 11 Aug 2014 12:35:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGsZA-00021R-2o for qemu-devel@nongnu.org; Mon, 11 Aug 2014 12:35:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGsZ9-000210-RK for qemu-devel@nongnu.org; Mon, 11 Aug 2014 12:35:24 -0400 Message-ID: <53E8F0C9.90604@redhat.com> Date: Mon, 11 Aug 2014 10:35:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407565595-18861-1-git-send-email-sanidhya.iiith@gmail.com> <1407565595-18861-5-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1407565595-18861-5-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hcJ9FOxnmTrXf8N0i9okLP4en4J5urCGm" Subject: Re: [Qemu-devel] [RFC PATCH v3 4/6] VMState test: querying the vmstate testing process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hcJ9FOxnmTrXf8N0i9okLP4en4J5urCGm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/09/2014 12:26 AM, Sanidhya Kashyap wrote: > This patch has been updated to provide the following information: > * Added a new return value in the form of devices' info that provides > the device name as well as the version number.=20 > * provides the hmp interface - info test_vmstates and qmp interface - > query-test-vmstates to obtain the information about the running=20 > vmstate testing process.=20 Patch changelog information belongs... >=20 > Signed-off-by: Sanidhya Kashyap > --- =2E..after the --- separator. > hmp-commands.hx | 4 +++- > hmp.c | 31 +++++++++++++++++++++++++++++++ > hmp.h | 1 + > monitor.c | 7 +++++++ > qapi-schema.json | 37 +++++++++++++++++++++++++++++++++++++ > qmp-commands.hx | 28 ++++++++++++++++++++++++++++ > savevm.c | 29 +++++++++++++++++++++++++++++ > 7 files changed, 136 insertions(+), 1 deletion(-) >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > @@ -1799,13 +1801,13 @@ ETEXI > "period: (optional) sleep interval in millisecon= ds between each iteration", > .mhandler.cmd =3D hmp_test_vmstates, > }, > + > STEXI > @item test_vmstates > @findex test_vmstates > dumps and reads the device state's data from the memory for testing pu= rpose > ETEXI > =20 > - > STEXI Spurious whitespace changes? > +++ b/qapi-schema.json > @@ -3528,3 +3528,40 @@ > 'data': {'*iterations': 'int', > '*period': 'int', > '*devices': [ 'QemuDevice' ] } } > + > +## > +# @VMStateLogStateInfo Having State in the name twice sounds redundant. Would 'VMStateLogInfo' be sufficient? > +{ 'type': 'VMStateLogStateInfo', > + 'data': { 'current-iteration': 'int', > + 'iterations': 'int', > + 'period': 'int', > + 'devices': [ 'QemuDevice' ] } } > + > +## > +# @query-test-vmstates > +# > +# Get the current parameters value of the vmstate testing process. > +# > +# Returns VMStateLogStateInfo structure. > +# > +# Since 2.2 > +## > +{ 'command': 'query-test-vmstates', 'returns': 'VMStateLogStateInfo' }= > +Example: > + > +-> { "execute": "query-test-vmstates" } > +<- { "return": { > + "current_iteration": 3, Doesn't match the spelling documented in the .json. > + "iterations": 100, > + "period": 100, > + "devices": [ { 'device': 'hpet', 'version': 2 }, QMP uses ", not '. Please paste an actual example (possibly trimmed, if the list of devices is otherwise too huge) rather than trying to write it by hand. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hcJ9FOxnmTrXf8N0i9okLP4en4J5urCGm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6PDJAAoJEKeha0olJ0NqX6AH/iJ2ZUPNEYoj6YT2M7Ku/n17 yBSrIMTtMc2PN9nXs1lkqaUhM2hDNSEVchWFj54uDjkUzlyxWiCjYODxY/99Ykwp RQRPWgZ0PSlVdPWu9yVg0BuBd8+DcOTIQN4KOjxmfBrteNuxHGUcuyCcSslB+rSn NlI5H6xUGEaJavx30Qw3CgiU7i8y4F2yBtGkyzse2QEf/g7YQDCDLj0E2O65Lxgs nM7SiMyIojyrcc3cTSiMxKeds8MdOroVLLXn7SsnKV2RtzPDzA+PfWncxVMatSXN 08BXNfDoRkv+tXQUBYfAgY789Wo8eZTPGJwAPi5M6UCZS1idiRf1G48bbp81rfE= =H402 -----END PGP SIGNATURE----- --hcJ9FOxnmTrXf8N0i9okLP4en4J5urCGm--