From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGsyF-0006Wh-04 for qemu-devel@nongnu.org; Mon, 11 Aug 2014 13:01:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGsy9-0001wJ-V6 for qemu-devel@nongnu.org; Mon, 11 Aug 2014 13:01:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGsy9-0001wD-MU for qemu-devel@nongnu.org; Mon, 11 Aug 2014 13:01:13 -0400 Message-ID: <53E8F6D3.8070908@redhat.com> Date: Mon, 11 Aug 2014 11:01:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407767399-3030-1-git-send-email-dgilbert@redhat.com> <1407767399-3030-21-git-send-email-dgilbert@redhat.com> In-Reply-To: <1407767399-3030-21-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vW2TEH4UnfIb1bttnuf9qXsSU8T4BGqgx" Subject: Re: [Qemu-devel] [PATCH v2 20/43] migrate_start_postcopy: Command to trigger transition to postcopy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vW2TEH4UnfIb1bttnuf9qXsSU8T4BGqgx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/11/2014 08:29 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > Once postcopy is enabled (with migrate_set_capability), the migration > will still start on precopy mode. To cause a transition into postcopy > the: >=20 > migrate_start_postcopy >=20 > command must be issued. Postcopy will start sometime after this > (when it's next checked in the migration loop). >=20 > Issuing the command before migration has started will error, > and issuing after it has finished is ignored. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > hmp-commands.hx | 15 +++++++++++++++ > hmp.c | 7 +++++++ > hmp.h | 1 + > include/migration/migration.h | 3 +++ > migration.c | 22 ++++++++++++++++++++++ > qapi-schema.json | 8 ++++++++ > qmp-commands.hx | 19 +++++++++++++++++++ > 7 files changed, 75 insertions(+) >=20 Reviewed-by: Eric Blake > +++ b/qapi-schema.json > @@ -538,6 +538,14 @@ > { 'command': 'query-migrate-capabilities', 'returns': ['MigrationCap= abilityStatus']} > =20 > ## > +# @migrate-start-postcopy > +# > +# Switch migration to postcopy mode > +# > +# Since: 2.2 > +{ 'command': 'migrate-start-postcopy' } > + Interface looks reasonable. I haven't closely reviewed much else in the series yet. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vW2TEH4UnfIb1bttnuf9qXsSU8T4BGqgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6PbTAAoJEKeha0olJ0NqdUwH/0Rna6LlSNASJRnfFwqSkDPN lv1/6T4L4SeR2Dh3YkNA9KGFijFJ4eW6UpGemD64uPpEaauGRRj61rjIYQRMam4a HfSVdI66Nz4FPdCu+dVwDDcl0vDrjSM5/+XlKTkoLnM+PdMLP2zqTHDk0UFf5vr7 FVgprF++qGPJ3aAt7MPwQgnDwrmmWucTVlbJkKRQWgH7I+u05hEKUqZqSTQHf47Q Xzs+DLUVR51CJXiqc7DPIkdO2BFh0si4R8KNoaEVTN3Ct5im5PiuOZKuT2DQVCzE 1e2zlu/L2Dg8qpPqH0J62a1UscHI2uS+XyYAgNbuYUflTZZHTe1DpZpMajr8B8s= =exoG -----END PGP SIGNATURE----- --vW2TEH4UnfIb1bttnuf9qXsSU8T4BGqgx--