From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGuM3-0000xv-Tw for qemu-devel@nongnu.org; Mon, 11 Aug 2014 14:30:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGuLy-0000tK-OH for qemu-devel@nongnu.org; Mon, 11 Aug 2014 14:29:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGuLy-0000tE-Gn for qemu-devel@nongnu.org; Mon, 11 Aug 2014 14:29:54 -0400 Message-ID: <53E90B9D.4050802@redhat.com> Date: Mon, 11 Aug 2014 12:29:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407767399-3030-1-git-send-email-dgilbert@redhat.com> <1407767399-3030-2-git-send-email-dgilbert@redhat.com> In-Reply-To: <1407767399-3030-2-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4pGppJkNnD7f5MBvGQ3xx81dnlupdGveq" Subject: Re: [Qemu-devel] [PATCH v2 01/43] qemu_ram_foreach_block: pass up error value, and down the ramblock name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: aarcange@redhat.com, yamahata@private.email.ne.jp, lilei@linux.vnet.ibm.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4pGppJkNnD7f5MBvGQ3xx81dnlupdGveq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/11/2014 08:29 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > check the return value of the function it calls and error if it's none-= 0 s/none/non/ > Fixup qemu_rdma_init_one_block that is the only current caller, > and __qemu_rdma_add_block the only function it calls using it. >=20 > Pass the name of the ramblock to the function; helps in debugging. >=20 > Signed-off-by: Dr. David Alan Gilbert > --- > exec.c | 10 ++++++++-- > include/exec/cpu-common.h | 4 ++-- > migration-rdma.c | 4 ++-- > 3 files changed, 12 insertions(+), 6 deletions(-) >=20 > +++ b/migration-rdma.c > @@ -595,10 +595,10 @@ static int __qemu_rdma_add_block(RDMAContext *rdm= a, void *host_addr, > * in advanced before the migration starts. This tells us where the RA= M blocks > * are so that we can register them individually. > */ > -static void qemu_rdma_init_one_block(void *host_addr, > +static int qemu_rdma_init_one_block(const char *block_name, void *host= _addr, > ram_addr_t block_offset, ram_addr_t length, void *opaque) > { > - __qemu_rdma_add_block(opaque, host_addr, block_offset, length); > + return __qemu_rdma_add_block(opaque, host_addr, block_offset, leng= th); We really shouldn't be using __qemu naming in our source, as that namespace is reserved for the compiler/libc (this patch didn't introduce it, so if you fix it, do it as a separate cleanup). Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --4pGppJkNnD7f5MBvGQ3xx81dnlupdGveq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6QudAAoJEKeha0olJ0NqDusH/31rkYW6yHCjU2GE4kwGcGBH uhAg34oZSIgRIj63aNTi9Qmg0rS8/RQk/UIOT3dUrk6NXaX0W1AFJIHq1No8iQhc HEGzRkp8oknyuGqR7b5JScSZ5CS9IpWuhoy4S9Blfu2def2hvl8xaD9fR1a8zn74 He/Fnze/FCLF/HB+FlCR8y1BFAC8Gk3URmoh0n6ESrqDOHcPBZhSFlo8GfKnKTdi Ru8kftdk4e7D7hPrAXvZzjgbl+7/xJeqKFa1ITlZys+ln2GP0llXEY4ki5phvf0y PBbsVOUk+nUhqJfFGCeESfOzSDKOCXGRRD1880vuZg8ghS1N+IWwV6aGGBf/kC4= =6YV3 -----END PGP SIGNATURE----- --4pGppJkNnD7f5MBvGQ3xx81dnlupdGveq--