From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33047) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGvdg-0003M7-As for qemu-devel@nongnu.org; Mon, 11 Aug 2014 15:52:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGvdb-0003ja-Uq for qemu-devel@nongnu.org; Mon, 11 Aug 2014 15:52:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGvdb-0003jW-LZ for qemu-devel@nongnu.org; Mon, 11 Aug 2014 15:52:11 -0400 Message-ID: <53E91EDB.90409@redhat.com> Date: Mon, 11 Aug 2014 13:51:55 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407749661-11640-1-git-send-email-arei.gonglei@huawei.com> <1407749661-11640-2-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1407749661-11640-2-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jJL2v0MQELCEXXQbQO9ugrQLStKaB93V6" Subject: Re: [Qemu-devel] [PATCH 1/2] qemu-char: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, mst@redhat.com, wangxinxin.wang@huawei.com, peter.huangpeng@huawei.com, kraxel@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jJL2v0MQELCEXXQbQO9ugrQLStKaB93V6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/11/2014 03:34 AM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Technically, fcntl(soc, F_SETFL, O_NONBLOCK) > is incorrect since it clobbers all other file flags. > We can use F_GETFL to get the current flags, set or > clear the O_NONBLOCK flag, then use F_SETFL to set the flags. >=20 > Using the qemu_set_nonblock() wrapper. >=20 > Signed-off-by: Wangxin > Signed-off-by: Gonglei > --- > qemu-char.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jJL2v0MQELCEXXQbQO9ugrQLStKaB93V6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6R7bAAoJEKeha0olJ0NqmGEH/1X2w4gKTd62ypoIhoz3qqbY l9/rGr6ffduCbVEwp7ohpNlZMZw1qd7AbC8sbUzYd5p1Vf9YOMQKJXEOA7ClJzCp QYOeq7DnsDFCOgKS/ETMtlaM9Jvi2+PdKTOUi0nX6lDHxtu8ZnbQUOe450ZpgUl/ WT5d+R1vplsjHziNQW0VkEnAAyAw5IMcBu/Gc7tHZmmAFqSDbWR4Nlzx2mGsU1Uk 20+JLCVLn55oAFUvxTuAk+hHQgYYSRxyQhLR7sIAlzC/BkhjlavFqiDoCfvnHm5F nTROsMTMlXrzLWe2w/Bmpql6bvNeE6mvntF+NMhS+62SQ2BmW0SFHXXqaY6trN8= =rEAq -----END PGP SIGNATURE----- --jJL2v0MQELCEXXQbQO9ugrQLStKaB93V6--