From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33088) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGvds-0003UO-Fx for qemu-devel@nongnu.org; Mon, 11 Aug 2014 15:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XGvdo-0003o7-4Y for qemu-devel@nongnu.org; Mon, 11 Aug 2014 15:52:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XGvdn-0003nR-RY for qemu-devel@nongnu.org; Mon, 11 Aug 2014 15:52:24 -0400 Message-ID: <53E91EF0.2070809@redhat.com> Date: Mon, 11 Aug 2014 13:52:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407749661-11640-1-git-send-email-arei.gonglei@huawei.com> <1407749661-11640-3-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1407749661-11640-3-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pHUopndXBO1lxqLNe8LhMpa1QeuiDH4wk" Subject: Re: [Qemu-devel] [PATCH 2/2] channel-posix: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, mst@redhat.com, wangxinxin.wang@huawei.com, peter.huangpeng@huawei.com, kraxel@redhat.com, stefanha@redhat.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pHUopndXBO1lxqLNe8LhMpa1QeuiDH4wk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/11/2014 03:34 AM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Technically, fcntl(soc, F_SETFL, O_NONBLOCK) > is incorrect since it clobbers all other file flags. > We can use F_GETFL to get the current flags, set or > clear the O_NONBLOCK flag, then use F_SETFL to set the flags. >=20 > Using the qemu_set_nonblock() wrapper. >=20 > Signed-off-by: Gonglei > Signed-off-by: Wangxin > --- > qga/channel-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pHUopndXBO1lxqLNe8LhMpa1QeuiDH4wk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6R7wAAoJEKeha0olJ0NqCK0IAJEdbLbjW3ivyDJnDhx86JZ/ +hTZ0ToQhnNVa9zFukE5H/ZrARfQZ8AmpsINuZX7ebZ1qiQAeB80SVc26V+rpd9G s1rfptQPLjt40MqJbDIaw8kiHjFQnnXV/2BEhdud3f+S3NCvfrw0z+d30gdRfa8l JoQqr/0Bv2CVof8p8UTNExrU40U7mZWT39ThaGLLNSIJswmz8t2lTq5ph4RRc11r Df5hGaanm5UbCTP2HY78NYg5FvS2NLNYRjqTFhQaWcaql+iMFBRiESO4NDFWP3Am R5CgQttZtj7jByJ8R8bnnGmiBkVlNdcANPkJM557k2KOb+lgqTD4//ZRxtABQsw= =vxiT -----END PGP SIGNATURE----- --pHUopndXBO1lxqLNe8LhMpa1QeuiDH4wk--