From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XH9dz-0001zf-GQ for qemu-devel@nongnu.org; Tue, 12 Aug 2014 06:49:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XH9ds-0008R9-8L for qemu-devel@nongnu.org; Tue, 12 Aug 2014 06:49:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41816 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XH9ds-0008Qu-1h for qemu-devel@nongnu.org; Tue, 12 Aug 2014 06:49:24 -0400 Message-ID: <53E9F132.4070001@suse.de> Date: Tue, 12 Aug 2014 12:49:22 +0200 From: Alexander Graf MIME-Version: 1.0 References: <8482219871810d095f8b6e497902b4b48f69b108.1407116648.git.peter.crosthwaite@xilinx.com> <53E9DC28.9050105@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 12/16] qdev: gpio: Remove qdev_init_gpio_out x1 restriction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , Paolo Bonzini , "qemu-devel@nongnu.org Developers" , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= On 12.08.14 12:35, Peter Crosthwaite wrote: > On Tue, Aug 12, 2014 at 7:19 PM, Alexander Graf wrote: >> On 04.08.14 03:58, Peter Crosthwaite wrote: >>> Previously this was restricted to a single call per-dev/per-name. With >>> the conversion of the GPIO output state to QOM the implementation can >>> now handle repeated calls. Remove the restriction. >>> >>> Signed-off-by: Peter Crosthwaite >>> --- >>> >>> hw/core/qdev.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >>> index 77b0b09..bf2c227 100644 >>> --- a/hw/core/qdev.c >>> +++ b/hw/core/qdev.c >>> @@ -366,8 +366,7 @@ void qdev_init_gpio_out_named(DeviceState *dev, >>> qemu_irq *pins, >> >> Maybe rename it to _add rather than _init then? >> > Hmmm that's a tree-wide (unless we allow the _named variant to have > inconsistent naming with the well used qdev_init_gpio_out). This > change does make the behaviour consistent with current > qdev_init_gpio_in behav where you are already allowed multiple calls: > > qdev_init_gpio_in(dev, foo, ...); > qdev_init_gpio_in(dev, bar, ...); > > Perhaps fix them both together with the tree wide as follow up? Sure, a follow-up works for me :). Alex