From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHAS0-0002n8-HJ for qemu-devel@nongnu.org; Tue, 12 Aug 2014 07:41:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHARq-0000Bd-Nt for qemu-devel@nongnu.org; Tue, 12 Aug 2014 07:41:12 -0400 Message-ID: <53E9FD46.1040509@gmail.com> Date: Tue, 12 Aug 2014 06:40:54 -0500 From: Tom Musta MIME-Version: 1.0 References: <1407785009-6538-1-git-send-email-tommusta@gmail.com> <20140812030616.GE23065@voom.redhat.com> In-Reply-To: <20140812030616.GE23065@voom.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/8] target-ppc: Bug Fixes for 64 Bit FXU Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de On 8/11/2014 10:06 PM, David Gibson wrote: > On Mon, Aug 11, 2014 at 02:23:21PM -0500, Tom Musta wrote: >> These patches fix assorted bugs in the emulation of Power Fixed Point Unit >> instructions. >> >> All instructions have been thorougly tested by running millions of random >> patterns through actual hardware and comparing the results against QEMU. >> The bugs all appear to be limited to 64 bit implementations. > > I think understanding these fixes would be easier if each commit > message included some example inputs for which the existing code > generates the wrong results. > Thanks, David, for the feedback. I will add some sample data patterns.