From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHC0U-0000JW-8p for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHC0L-0000k9-P7 for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:20:54 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45591 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHC0L-0000jy-I4 for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:20:45 -0400 Message-ID: <53EA14AB.60404@suse.de> Date: Tue, 12 Aug 2014 15:20:43 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1407847054-672-1-git-send-email-stefanha@redhat.com> <1407847054-672-3-git-send-email-stefanha@redhat.com> <87mwb9ooft.fsf@blackfin.pond.sub.org> In-Reply-To: <87mwb9ooft.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] libqtest: launch QEMU with QEMU_AUDIO_DRV=none List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Gerd Hoffmann Am 12.08.2014 14:57, schrieb Markus Armbruster: > Stefan Hajnoczi writes: >=20 >> No test case actually uses the audio backend. Disable audio to preven= t >> errors on hosts with no sound hardware present: >> >> GTESTER check-qtest-aarch64 >> sdl: SDL_OpenAudio failed >> sdl: Reason: No available audio device >> sdl: SDL_OpenAudio failed >> sdl: Reason: No available audio device >> audio: Failed to create voice `lm4549.out' >> >> Signed-off-by: Stefan Hajnoczi >> --- >> tests/libqtest.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/libqtest.c b/tests/libqtest.c >> index 98e8f4b..2abb6f2 100644 >> --- a/tests/libqtest.c >> +++ b/tests/libqtest.c >> @@ -165,7 +165,7 @@ QTestState *qtest_init(const char *extra_args) >> =20 >> s->qemu_pid =3D fork(); >> if (s->qemu_pid =3D=3D 0) { >> - command =3D g_strdup_printf("exec %s " >> + command =3D g_strdup_printf("QEMU_AUDIO_DRV=3Dnone exec %s " >> "-qtest unix:%s,nowait " >> "-qtest-log /dev/null " >> "-qmp unix:%s,nowait " >=20 > Gerd (cc'ed) solved this differently in his patch[*]. I'm fine with > either. Hm, Gerd's patch seems to only touch audio-specific tests but not the generic qom-test for instance. What about doing Gerd's setenv() in Stefan's generic code? Not cluttering the shell call even more would make it easier to some day convert to an array-based API. Not a priority though. Cheers, Andreas > [*] https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg03087.h= tml --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg