From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44658) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHCWK-0002RL-CB for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:53:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHCWE-0005EC-H3 for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:53:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHCWE-0005Dx-91 for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:53:42 -0400 Message-ID: <53EA1C62.4080006@redhat.com> Date: Tue, 12 Aug 2014 07:53:38 -0600 From: Eric Blake MIME-Version: 1.0 References: <1406862751-24008-1-git-send-email-sanidhya.iiith@gmail.com> <1406862751-24008-4-git-send-email-sanidhya.iiith@gmail.com> In-Reply-To: <1406862751-24008-4-git-send-email-sanidhya.iiith@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KIkPtohSi2wP8go54E51aPkJe6RQJhje4" Subject: Re: [Qemu-devel] [PATCH v5 3/6] BitmapLog: get the information about the parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sanidhya Kashyap , qemu list Cc: "Dr. David Alan Gilbert" , Juan Quintela This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KIkPtohSi2wP8go54E51aPkJe6RQJhje4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/31/2014 09:12 PM, Sanidhya Kashyap wrote: > No functional change except the variable name. This comment feels more like it is a changelog of what is different from v4. If so, it belongs... >=20 > Signed-off-by: Sanidhya Kashyap > --- =2E..here, after the --- separator. It makes no sense in isolation in qemu.git (where v1 through v4 do not appear), but is there only to aid reviewers on list (who DO see prior versions, and want to see if you took into account earlier review comments). > + if (info) { > + monitor_printf(mon, "current iteration: %ld\n", > + info->current_iteration); Won't compile on 32-bit. Per patch 2/6, info->current_iteration is int64_t, but %ld might be 32-bit. Furthermore, patch 2/6 had an (arbitrary?) limit of 100,000 as the maximum iteration request, which fits in a 32-bit value to begin with, so using int64_t to hold the value is overkill. > +Example: > + > +-> { "execute": "query-log-dirty-bitmap" } > +<- { "return": { > + "current-iteration": 3 > + "iterations": 10 > + "period": 100 } } That's not valid JSON. You are missing two commas. It's best to paste an actual QMP result, rather than trying to write it by hand. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KIkPtohSi2wP8go54E51aPkJe6RQJhje4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6hxiAAoJEKeha0olJ0NqIcUH/3C0BzrKNaW9uLk57/DAMWO+ tNfM+MHrdTDmBJb9tRmdI4uVeWI6GdJNcbmiEpRsfSSvpP97JZWE+Q5TA0dkfIEG CrwDAIhK8B4WZZNxp4eLbJEp0kynfqiucn0F58r5edOsOsQJwRRCxYdaZVy2oK8f FxJ/VNjq3AtIeUA8JwcYtUkiHW4gryN/l6keM6SKksD4933kQkdweyOZHsI6q3U3 gjPzDw8ZEWxt81erQgwxGMrA7HJopJaSVZfICPGd/DmK0k+eEPsF2Mjnb/v+q/E6 qqzjxyOaHySMqNC6YPdDkLOypZwUGMSmKYMcWEQUhtsioOkAGG27KK/o6fRNVSA= =F4M6 -----END PGP SIGNATURE----- --KIkPtohSi2wP8go54E51aPkJe6RQJhje4--