From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45579)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XHCZy-00048r-GG
	for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:57:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XHCZs-0006da-Uv
	for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:57:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64760)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XHCZs-0006dV-Lk
	for qemu-devel@nongnu.org; Tue, 12 Aug 2014 09:57:28 -0400
Message-ID: <53EA1D44.1040503@redhat.com>
Date: Tue, 12 Aug 2014 07:57:24 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1406862751-24008-1-git-send-email-sanidhya.iiith@gmail.com>
	<1406862751-24008-6-git-send-email-sanidhya.iiith@gmail.com>
In-Reply-To: <1406862751-24008-6-git-send-email-sanidhya.iiith@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="sSNVS1fPH1AMLVECFqse2mkklpocmKNX3"
Subject: Re: [Qemu-devel] [PATCH v5 5/6] BitmapLog: set the period of the
 dump bitmap process
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Sanidhya Kashyap <sanidhya.iiith@gmail.com>, qemu list <qemu-devel@nongnu.org>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--sSNVS1fPH1AMLVECFqse2mkklpocmKNX3
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 07/31/2014 09:12 PM, Sanidhya Kashyap wrote:
> No functional change except the variable name -- frequency has been mod=
ified
> to period.

This sounds like patch revision information that belongs...

>=20
> Signed-off-by: Sanidhya Kashyap <sanidhya.iiith@gmail.com>
> ---

=2E..here.

>  hmp-commands.hx  | 15 +++++++++++++++
>  hmp.c            | 12 ++++++++++++
>  hmp.h            |  1 +
>  qapi-schema.json | 12 ++++++++++++
>  qmp-commands.hx  | 24 ++++++++++++++++++++++++
>  savevm.c         | 14 ++++++++++++++
>  6 files changed, 78 insertions(+)
>=20
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index dcdc465..b36927d 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1820,6 +1820,21 @@ STEXI
>  Cancel the current bitmap dump process
>  ETEXI
> =20
> +    {
> +        .name       =3D "ldbsf|log_dirty_bitmap_set_period",

As in 2/6, don't try to use a short 'ldbsf' name.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--sSNVS1fPH1AMLVECFqse2mkklpocmKNX3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg

iQEcBAEBCAAGBQJT6h1EAAoJEKeha0olJ0Nq6X0IAKdSbG7UCNZN999MX8ch882h
dkTCG/5CjjaeSbkL25r5FntlK2RP9z+jgAIDVDFh2t5YPXhOhzNug3jX4Xn0Qwca
7oCwb62sGPqjb9GxK4sXU7yA9L1Ltr5L/SSvyfrEaESwSV+8KO9iu9ZTBMddrpSH
W5wM04ZTG4dOUnlN9koWZztB38X55TmaKdmg2VW2QgMCRoBAQkI1sAqb22t8vQfn
DLCF1i29Ap+mGFcmF1M02bwUBMizoWzj6fXZHPkgzESSdfoiSAvN0wpySsHb/mNY
kdvj3LSHiqkMYEa4ARBNUzFqcxciYakFhiFCdRlltfrltbb3PGcWrya9P9PW3Gc=
=GhiJ
-----END PGP SIGNATURE-----

--sSNVS1fPH1AMLVECFqse2mkklpocmKNX3--