From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHE7w-0003p0-5h for qemu-devel@nongnu.org; Tue, 12 Aug 2014 11:36:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHE7r-0000XY-7j for qemu-devel@nongnu.org; Tue, 12 Aug 2014 11:36:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHE7q-0000XS-Vc for qemu-devel@nongnu.org; Tue, 12 Aug 2014 11:36:39 -0400 Message-ID: <53EA3481.2060503@redhat.com> Date: Tue, 12 Aug 2014 09:36:33 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407854125-25068-1-git-send-email-danielhb@linux.vnet.ibm.com> In-Reply-To: <1407854125-25068-1-git-send-email-danielhb@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rwl0mWPiieRNCDsjLBKWDD8CersQqDLCh" Subject: Re: [Qemu-devel] [PATCH] block.curl: adding 'curltimeout' option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Daniel Henrique Barboza , Qemu Devel Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rwl0mWPiieRNCDsjLBKWDD8CersQqDLCh Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/12/2014 08:35 AM, Daniel Henrique Barboza wrote: > The curl hardcoded timeout (5 seconds) sometimes is not long > enough depending on the remote server configuration and network > traffic. The user should be able to set how much long he is > willing to wait for the connection. >=20 > Adding a new option to set this timeout gives the user this > flexibility. The previous default timeout of 5 seconds will be > used if this option is not present. >=20 > Signed-off-by: Daniel Henrique Barboza > --- > block/curl.c | 13 ++++++++++++- > qemu-options.hx | 10 ++++++++-- > 2 files changed, 20 insertions(+), 3 deletions(-) It would be really nice if we could get curl support added to BlockdevOptionsBase, so that the QMP command for hot-plugging a curl drive could also control this option. (Hmm, I wonder why curl is omitted from the list of TODOs in qapi/block-core.json under BlockdevOptionsBase). > @example > -qemu-img create -f qcow2 -o backing_file=3D'json:@{"file.driver":"http= s",, "file.url":"https://user:password@@vsphere.example.com/folder/test/t= est-flat.vmdk?dcPath=3DDatacenter&dsName=3Ddatastore1",, "file.sslverify"= :"off",, "file.readahead":"64k"@}' /tmp/test.qcow2 > +qemu-img create -f qcow2 -o backing_file=3D'json:@{"file.driver":"http= s",, "file.url":"https://user:password@@vsphere.example.com/folder/test/t= est-flat.vmdk?dcPath=3DDatacenter&dsName=3Ddatastore1",, "file.sslverify"= :"off",, "file.readahead":"64k",, "file.curltimeout":"10"@}' Since you are parsing curltimeout as a QEMU_OPT_NUMBER, it should be "file.curltimeout":10, not "file.curltimeout":"10". --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Rwl0mWPiieRNCDsjLBKWDD8CersQqDLCh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT6jSBAAoJEKeha0olJ0NqDCMH/3ib6qZdClB5mEh6RQvqE9i2 kglnRAoIhnG9Icf8/JW8SYL/qUIQb6d8+rx5aUi1X9z7a+NFHFHzkfu4glE0BMS6 EkfqcTQxHpjubaO+UHepz9nZr9tQhRwqamaK4AnhLib66w2xCfOl+HqW/4HILOhQ xCtlGgPVBgcNuBPNgbGyxa9ThSxLMavYvoPsapIyCHhWSWAQ2CDuSj9SwnzR9yTx hEg5ILWSsvRZHEy4y35mEnlL6fg5M1CD+RsRZdGAKMAPBteGl8s5UxsO59i8sPuh fhUEWwtOesAwq4S6fgdCsfXTeiSJZdzZO+XUT71Cqe3gK3+uVidNmFlzGQmLIZI= =xlg6 -----END PGP SIGNATURE----- --Rwl0mWPiieRNCDsjLBKWDD8CersQqDLCh--