From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHG3l-0004uZ-VF for qemu-devel@nongnu.org; Tue, 12 Aug 2014 13:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHG3b-0008HE-CV for qemu-devel@nongnu.org; Tue, 12 Aug 2014 13:40:33 -0400 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:58856) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHG3b-0008H8-4V for qemu-devel@nongnu.org; Tue, 12 Aug 2014 13:40:23 -0400 Received: by mail-pd0-f174.google.com with SMTP id fp1so12894749pdb.5 for ; Tue, 12 Aug 2014 10:40:21 -0700 (PDT) Sender: Richard Henderson Message-ID: <53EA5176.5090303@twiddle.net> Date: Tue, 12 Aug 2014 07:40:06 -1000 From: Richard Henderson MIME-Version: 1.0 References: <6aae8f38cb28cb54df8348adc9d4c0aa1f0cd3d7.1407527535.git.atar4qemu@gmail.com> In-Reply-To: <6aae8f38cb28cb54df8348adc9d4c0aa1f0cd3d7.1407527535.git.atar4qemu@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-sparc64: implement Short Floating-Point Store Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Artyom Tarasenko , qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, mark.cave-ayland@ilande.co.uk On 08/08/2014 10:48 AM, Artyom Tarasenko wrote: > Implement Short Floating-Point Store Instructions as described > in the chapter 13.5.2 of UltraSPARC-IIi User's Manual. > > Particularly this instructions are used by NetBSD 4.0.1+ /sparc64 > > Signed-off-by: Artyom Tarasenko > --- > > With this patch applied on top of cmd646 patches it's possible to install > and boot NetBSD 6.1.4 /sparc64. > > target-sparc/ldst_helper.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/target-sparc/ldst_helper.c b/target-sparc/ldst_helper.c > index 03bd9f9..ca65e8d 100644 > --- a/target-sparc/ldst_helper.c > +++ b/target-sparc/ldst_helper.c > @@ -2154,7 +2154,6 @@ void helper_stf_asi(CPUSPARCState *env, target_ulong addr, int asi, int size, > unsigned int i; > target_ulong val; > > - helper_check_align(env, addr, 3); > addr = asi_address_mask(env, asi, addr); > > switch (asi) { > @@ -2192,7 +2191,21 @@ void helper_stf_asi(CPUSPARCState *env, target_ulong addr, int asi, int size, > } > > return; > + case 0xd2: /* 16-bit floating point load primary */ > + case 0xd3: /* 16-bit floating point load secondary */ > + case 0xda: /* 16-bit floating point load primary, LE */ > + case 0xdb: /* 16-bit floating point load secondary, LE */ > + helper_check_align(env, addr, 1); > + /* Fall through */ > + case 0xd0: /* 8-bit floating point load primary */ > + case 0xd1: /* 8-bit floating point load secondary */ > + case 0xd8: /* 8-bit floating point load primary, LE */ > + case 0xd9: /* 8-bit floating point load secondary, LE */ > + val = env->fpr[rd/2].l.lower; > + helper_st_asi(env, addr, val, asi & 0x8d, ((asi & 2) >> 1) + 1); > + return; > default: > + helper_check_align(env, addr, 3); Good, as far as it goes. The comments should say "store" not "load". You might as well implement the corresponding load-short-f asis as well. r~