From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHpNp-0002O5-FJ for qemu-devel@nongnu.org; Thu, 14 Aug 2014 03:23:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHpNd-0003h7-IU for qemu-devel@nongnu.org; Thu, 14 Aug 2014 03:23:37 -0400 Received: from mga02.intel.com ([134.134.136.20]:28305) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHpNd-0003gy-Bh for qemu-devel@nongnu.org; Thu, 14 Aug 2014 03:23:25 -0400 Message-ID: <53EC63E8.1020602@intel.com> Date: Thu, 14 Aug 2014 15:23:20 +0800 From: "Chen, Tiejun" MIME-Version: 1.0 References: <1407836957-29098-1-git-send-email-tiejun.chen@intel.com> <20140814070934.GA30543@redhat.com> In-Reply-To: <20140814070934.GA30543@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v5][PATCH 0/4] xen: introduce new machine for IGD passthrough List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: pbonzini@redhat.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org, stefano.stabellini@eu.citrix.com On 2014/8/14 15:09, Michael S. Tsirkin wrote: > On Tue, Aug 12, 2014 at 05:49:13PM +0800, Tiejun Chen wrote: >> v5: >> >> * Simplify to make sure its really inherited from the standard one in patch #3 >> * Then drop the original patch #3 >> >> v4: >> >> * Rebase on latest tree >> * Drop patch #2 >> * Regenerate patches after Michael introduce patch #1 >> * We need to use this pci_type as a index to reuse I440FX_PCI_DEVICE() >> * Test: boot with a preinstalled winxp >> ./i386-softmmu/qemu-system-i386 -hda winxp-32.img -m 2560 -boot c -machine pc >> >> v3: >> >> * Drop patch #4 >> * Add one patch #1 from Michael >> * Rebase >> * In./i386-softmmu/qemu-system-i386 -hda test.img -m 2560 -boot c -machine pc >> >> v2: >> >> * Fix some coding style >> * New patch to separate i440fx_init >> * Just add prefix with XEN_IGD_PASSTHROUGH/xen_igd_passthrough >> * Based on patch #2 to regenerate >> * Unify prefix with XEN_IGD_PASSTHROUGH/xen_igd_passthrough like patch #3 >> * Test: boot with a preinstalled ubuntu 14.04 >> ./i386-softmmu/qemu-system-i386 -hda test.img -m 2560 -boot c -machine pc >> >> As we discussed we need to create a separate machine to support current >> IGD passthrough. > > That's a clean way to add a new machine so I will queue this up, but I > note this does not do anything by itself. So I'll keep it in my queue - Yes, currently its just useless. As you know, to support IGD passthrough involves many things, qemu, xen, native driver, and so forth. So I want to send them separately to avoid too many comments I need to address one time. > this way you don't need to re-post - but I think we should defer merging > until we see the actual users. Understood. Looks I can start to step next to push forward the remains. Thanks for your time and comments. Tiejun > >> ---------------------------------------------------------------- >> Michael S. Tsirkin (1): >> i440fx: make types configurable at run-time >> >> Tiejun Chen (3): >> pc_init1: pass parameters just with types >> xen:hw:pci-host:piix: create host bridge to passthrough >> xen:hw:i386:pc_piix: introduce new machine for IGD passthrough >> >> hw/i386/pc_piix.c | 60 +++++++++++++++++++++++++++++++++++++++++++++++++++++++----- >> hw/pci-host/piix.c | 24 +++++++++++++++++++----- >> include/hw/i386/pc.h | 8 +++++++- >> 3 files changed, 81 insertions(+), 11 deletions(-) >> >> Thanks >> Tiejun > >