From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHtLE-0006Yh-QH for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:37:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHtL7-0005Sr-Bk for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:37:12 -0400 Received: from mout.web.de ([212.227.15.14]:55863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHtL7-0005Sg-1O for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:37:05 -0400 Message-ID: <53EC9F51.7050304@web.de> Date: Thu, 14 Aug 2014 13:36:49 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1407740702-4086-1-git-send-email-tamlokveer@gmail.com> <1407740702-4086-4-git-send-email-tamlokveer@gmail.com> <20140814110652.GQ31346@redhat.com> In-Reply-To: <20140814110652.GQ31346@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Rnxm7qMt2f6CsNt1ps3DQ3q65dcJueFnq" Subject: Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Le Tan Cc: Stefan Weil , Knut Omang , qemu-devel@nongnu.org, Alex Williamson , Anthony Liguori , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rnxm7qMt2f6CsNt1ps3DQ3q65dcJueFnq Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2014-08-14 13:06, Michael S. Tsirkin wrote: > On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote: >> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE e= xists, >> add DMAR table to ACPI RSDT table. For now the DMAR table indicates th= at there >> is only one hardware unit without INTR_REMAP capability on the platfor= m. >> >> Signed-off-by: Le Tan >=20 > Could you add a unit test please? While unit tests would really be helpful, I'm afraid that's not in reach (GSoC is almost over). The good news is that we have pretty broad test coverage with both Linux and also Jailhouse already. Do you see unit tests as precondition for merging the series? Jan --Rnxm7qMt2f6CsNt1ps3DQ3q65dcJueFnq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlPsn1UACgkQitSsb3rl5xTK4QCgsCX47XMxlpXLQIvRTgQyk34f wDEAn00XsakVIJJqeIlq3uyvWsx3jPUD =vH4z -----END PGP SIGNATURE----- --Rnxm7qMt2f6CsNt1ps3DQ3q65dcJueFnq--