From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHtYy-0004jU-Si for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:51:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHtYr-0001ro-8X for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:51:24 -0400 Received: from mout.web.de ([212.227.17.11]:60825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHtYq-0001rj-TP for qemu-devel@nongnu.org; Thu, 14 Aug 2014 07:51:17 -0400 Message-ID: <53ECA2AB.6060907@web.de> Date: Thu, 14 Aug 2014 13:51:07 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1407740702-4086-1-git-send-email-tamlokveer@gmail.com> <1407740702-4086-4-git-send-email-tamlokveer@gmail.com> <20140814110652.GQ31346@redhat.com> <53EC9F51.7050304@web.de> <20140814114304.GA24157@redhat.com> In-Reply-To: <20140814114304.GA24157@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qVlLSOdI4a96HtK20SDMNxmO68k6BsjrN" Subject: Re: [Qemu-devel] [PATCH v3 3/5] intel-iommu: add DMAR table to ACPI tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Stefan Weil , Knut Omang , Le Tan , qemu-devel@nongnu.org, Alex Williamson , Anthony Liguori , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qVlLSOdI4a96HtK20SDMNxmO68k6BsjrN Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2014-08-14 13:43, Michael S. Tsirkin wrote: > On Thu, Aug 14, 2014 at 01:36:49PM +0200, Jan Kiszka wrote: >> On 2014-08-14 13:06, Michael S. Tsirkin wrote: >>> On Mon, Aug 11, 2014 at 03:05:00PM +0800, Le Tan wrote: >>>> Expose Intel IOMMU to the BIOS. If object of TYPE_INTEL_IOMMU_DEVICE= exists, >>>> add DMAR table to ACPI RSDT table. For now the DMAR table indicates = that there >>>> is only one hardware unit without INTR_REMAP capability on the platf= orm. >>>> >>>> Signed-off-by: Le Tan >>> >>> Could you add a unit test please? >> >> While unit tests would really be helpful, I'm afraid that's not in rea= ch >> (GSoC is almost over). The good news is that we have pretty broad test= >> coverage with both Linux and also Jailhouse already. >> >> Do you see unit tests as precondition for merging the series? >> >> Jan >> >=20 > Not a pre-requisite - it's very easy to add a unit test, > just add a case in test_acpi_tcg. So I can do it myself afterwards. >=20 Ah, ok, that's tests/bios-tables-test.c. Maybe Le can have a look if time is left. But hard pecils-down is already on the 18th. Jan --qVlLSOdI4a96HtK20SDMNxmO68k6BsjrN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlPsoqsACgkQitSsb3rl5xRY8QCgyXaARJQQu+P/pwFIL4IvMG89 lPQAoNnMeoqxo3gdBEhxZdY04m3S4Urd =UDg0 -----END PGP SIGNATURE----- --qVlLSOdI4a96HtK20SDMNxmO68k6BsjrN--