From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHtrH-0003iV-IV for qemu-devel@nongnu.org; Thu, 14 Aug 2014 08:10:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHtrB-0000Gp-75 for qemu-devel@nongnu.org; Thu, 14 Aug 2014 08:10:19 -0400 Received: from mout.web.de ([212.227.15.4]:62265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHtrA-0000Gd-SK for qemu-devel@nongnu.org; Thu, 14 Aug 2014 08:10:13 -0400 Message-ID: <53ECA71F.6070700@web.de> Date: Thu, 14 Aug 2014 14:10:07 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1407740702-4086-1-git-send-email-tamlokveer@gmail.com> <20140814111511.GS31346@redhat.com> In-Reply-To: <20140814111511.GS31346@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fdAcJuLXJ8xTtHDQSnlImAScPPKogeihQ" Subject: Re: [Qemu-devel] [PATCH v3 0/5] intel-iommu: introduce Intel IOMMU (VT-d) emulation to q35 chipset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Le Tan Cc: Stefan Weil , Knut Omang , qemu-devel@nongnu.org, Alex Williamson , Anthony Liguori , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fdAcJuLXJ8xTtHDQSnlImAScPPKogeihQ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2014-08-14 13:15, Michael S. Tsirkin wrote: > On Mon, Aug 11, 2014 at 03:04:57PM +0800, Le Tan wrote: >> Hi, >> >> These patches are intended to introduce Intel IOMMU (VT-d) emulation t= o q35 >> chipset. The major job in these patches is to add support for emulatin= g Intel >> IOMMU according to the VT-d specification, including basic responses t= o CSRs >> accesses, the logics of DMAR (DMA remapping) and DMA memory address >> translations. >=20 > Thanks! > Looks very good overall, I noted some coding style issues - I didn't > bother reporting each issue in every place where it appears - reported > each issue once only, so please find and fix all instances of each > issue. BTW, because I was in urgent need for virtual test environment for Jailhouse, I hacked interrupt remapping on top of Le's patches: http://git.kiszka.org/?p=3Dqemu.git;a=3Dshortlog;h=3Drefs/heads/queues/vt= d-intremap The approach likely needs further discussions and refinements but it already allows me to work on top with our hypervisor, and also Linux. You can see from the last commit that Le's work made it pretty easy to build this on top. Jan --fdAcJuLXJ8xTtHDQSnlImAScPPKogeihQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAlPspx8ACgkQitSsb3rl5xSE2wCeMwo5kIvTwEcPlQt2Rc6T7FYS UkYAn3GBZ/94UuDy0YRYZxmnLw1uvgnm =nD4r -----END PGP SIGNATURE----- --fdAcJuLXJ8xTtHDQSnlImAScPPKogeihQ--