From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHu7O-0000y0-B6 for qemu-devel@nongnu.org; Thu, 14 Aug 2014 08:27:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XHu7J-0005X3-CO for qemu-devel@nongnu.org; Thu, 14 Aug 2014 08:26:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XHu7J-0005Wy-3v for qemu-devel@nongnu.org; Thu, 14 Aug 2014 08:26:53 -0400 Message-ID: <53ECAB0A.3070608@redhat.com> Date: Thu, 14 Aug 2014 06:26:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1407287673-20308-1-git-send-email-eblake@redhat.com> <1407287673-20308-8-git-send-email-eblake@redhat.com> <87egwjjtbm.fsf@blackfin.pond.sub.org> In-Reply-To: <87egwjjtbm.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="btuT6hg1p6E8Q5euaE4uMfIHm807TLqQu" Subject: Re: [Qemu-devel] [PATCH v3 07/14] qapi: add some type check tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Luiz Capitulino , Fam Zheng , qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --btuT6hg1p6E8Q5euaE4uMfIHm807TLqQu Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/14/2014 03:47 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Demonstrate that the qapi generator silently parses confusing >> types, which may cause other errors later on. Later patches >> will update the expected results as the generator is made stricter. >> >> * tests/qapi-schema/data-array-empty.*: New files. >> * tests/qapi-schema/data-array-unknown.*: Likewise. >> * tests/qapi-schema/data-unknown.*: Likewise. >> * tests/qapi-schema/data-int.*: Likewise. >> * tests/qapi-schema/returns-unknown.*: Likewise. >> * tests/qapi-schema/returns-int.*: Likewise. >> * tests/qapi-schema/returns-array-bad.*: Likewise. >> * tests/Makefile (check-qapi-schema-y): Run them. >> >> +++ b/tests/qapi-schema/returns-array-bad.json >> @@ -0,0 +1 @@ >> +{ 'command': 'oops', 'data': [ 'str', 'str' ] } >=20 > The file name suggests you want to test 'returns' rather than 'data' he= re. D'oh. Definite reason to respin the series. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --btuT6hg1p6E8Q5euaE4uMfIHm807TLqQu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT7KsKAAoJEKeha0olJ0NqhI8IAI05wm5ad0KKCGCkmtaVqSgn VpzKvO4BI2kSHOjd9a3wdS10ezUx/OLL+9EnXthgIC14yKkKC5U/B0yl9TO9fU2o IrM+qK2kkcgCSslZ8hYAis4HfEhtv6dRdNn5bRNwpYN09h1UA6ngGwcaRnhQpB23 Rw2/Z6ikfjeRLE/hvZKB77DnIOf/e1N3Js/FDsV/xBNg0LSWnVq0CWSp+p5DX7bt M5vcRkRoRg6WT3IBme/hRZR3eYvtzSXdrqFz2aaNX+NlPaX12kG2Nt7c3OnQxFcX R0GRrsBTt7wmlwlUYbitqQdoFxTija5FvWfQVrsJVNxXnpCrb89DD+3TSYI4flg= =56+1 -----END PGP SIGNATURE----- --btuT6hg1p6E8Q5euaE4uMfIHm807TLqQu--