From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XHxfA-0004st-BS
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 12:14:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XHxf4-0003XO-7Z
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 12:14:04 -0400
Received: from mx1.redhat.com ([209.132.183.28]:30536)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XHxf3-0003XE-W4
	for qemu-devel@nongnu.org; Thu, 14 Aug 2014 12:13:58 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7EGDve9009606
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 14 Aug 2014 12:13:57 -0400
Message-ID: <53ECE03F.1080805@redhat.com>
Date: Thu, 14 Aug 2014 12:13:51 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1407966975-3723-1-git-send-email-jsnow@redhat.com>
	<1407966975-3723-6-git-send-email-jsnow@redhat.com>
	<20140814160923.GE24132@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140814160923.GE24132@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 29/32] ahci: properly shadow the TFD
	register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com



On 08/14/2014 12:09 PM, Stefan Hajnoczi wrote:
> On Wed, Aug 13, 2014 at 05:56:12PM -0400, John Snow wrote:
>> @@ -497,6 +495,8 @@ static void ahci_reset_port(AHCIState *s, int port)
>>       pr->scr_stat = 0;
>>       pr->scr_err = 0;
>>       pr->scr_act = 0;
>> +    pr->tfdata = 0x7F;
>
> Is it possible to avoid the magic number?
>

I can name it as AHCI_TFD_BOOT_VALUE or AHCI_TFD_INIT_VALUE or so. Same 
for the PxSIG boot value too. I don't think I can give any greater 
meaning to the value because it's just a boot signature that means "We 
haven't received an FIS yet."