From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIH6T-0005Z2-Gd for qemu-devel@nongnu.org; Fri, 15 Aug 2014 08:59:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIH6N-0002KL-9a for qemu-devel@nongnu.org; Fri, 15 Aug 2014 08:59:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:65077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIH6M-0002KG-Vq for qemu-devel@nongnu.org; Fri, 15 Aug 2014 08:59:27 -0400 Message-ID: <53EE0423.6020604@redhat.com> Date: Fri, 15 Aug 2014 14:59:15 +0200 From: Max Reitz MIME-Version: 1.0 References: <1406062723-28692-1-git-send-email-mreitz@redhat.com> <20140814153051.GA15821@noname.redhat.com> In-Reply-To: <20140814153051.GA15821@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-img: Allow source cache mode specification List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Peter Lieven , qemu-devel@nongnu.org, Stefan Hajnoczi On 14.08.2014 17:30, Kevin Wolf wrote: > Am 22.07.2014 um 22:58 hat Max Reitz geschrieben: >> Currently, qemu-img does not allow setting the cache mode for source >> images. However, it reads images generally only once, therefore a full >> writeback cache unnecessarily clutters the host cache. In case the user >> finds this undesirable, there has to be a way of disabling that cache. >> This series first introduces such a way for check, compare, convert and >> rebase and then (while at it) adds a cache mode switch to amend (which >> was missing so far). >> >> Peter already tried to add a BDRV_O_SEQUENTIAL mode to qemu-img convert. >> If we want to add such a mode (which in my opinion would be the logical >> consequence of this series), we may want to make it just another cache >> mode which can be selected by the user. > I would prefer if we used -t in all places where only one image is > used, so that I don't have to remember that supposedly check -r has only > an input image, whereas amend has only an output image. But that's > probably a matter of taste... > > If you don't want to change it, the implementation looks okay: > > Reviewed-by: Kevin Wolf In order to get this series in as fast as possible, I won't change it in this series anymore. Maybe we can add support for "-t" and "-T" being usable interchangably for such single-image commands in the future, but for now I hope the error messages will suffice. Max