From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIHbq-0000Hv-RP for qemu-devel@nongnu.org; Fri, 15 Aug 2014 09:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIHbk-0004X7-KY for qemu-devel@nongnu.org; Fri, 15 Aug 2014 09:31:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIHbk-0004X3-B2 for qemu-devel@nongnu.org; Fri, 15 Aug 2014 09:31:52 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7FDVpoT011271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 15 Aug 2014 09:31:51 -0400 Message-ID: <53EE0BC4.50705@redhat.com> Date: Fri, 15 Aug 2014 15:31:48 +0200 From: Max Reitz MIME-Version: 1.0 References: <1403294254-10245-1-git-send-email-mreitz@redhat.com> <20140815130818.GD3770@noname.redhat.com> In-Reply-To: <20140815130818.GD3770@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.2 v3 0/3] nbd: Adapt for dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, Stefan Hajnoczi On 15.08.2014 15:08, Kevin Wolf wrote: > Am 20.06.2014 um 21:57 hat Max Reitz geschrieben: >> For the NBD server to work with dataplane, it needs to correctly access >> the exported BDS. It makes the most sense to run both in the same >> AioContext, therefore this series implements methods for tracking a >> BDS's AioContext and makes NBD make use of this for keeping the clients >> connected to that BDS in the same AioContext. >> >> This series breaks compilation of NBD on Windows, because >> aio_set_fd_handler() is not available there yet. It should therefore not >> be merged until that function is available (which will probably not >> happen before qemu 2.2). >> >> >> v3: >> - Patch 1: Drop aio_notify(), because aio_set_fd_handler() will call it >> anyway [Stefan] >> >> v2: >> - Patch 1: Drop NBDClient::restart_write; checking whether >> NBDClient::send_coroutine is not NULL suffices [Paolo] > Dropped from the block branch because it breaks the win32 build: > > nbd.c: In function 'nbd_set_handlers': > nbd.c:1323:9: warning: implicit declaration of function 'aio_set_fd_handler' [-Wimplicit-function-declaration] > aio_set_fd_handler(client->exp->ctx, client->sock, > ^ > nbd.c:1323:9: warning: nested extern declaration of 'aio_set_fd_handler' [-Wnested-externs] > > And the resulting undefined references during linking. As stated by the cover letter you're replying to. :-) Sorry I did not pay enough attention when you merged this series to your tree, I should have explicitly warned you. Right, we need to implement aio_set_fd_handler() for the win32/win64 build before this series can really be merged. Paolo said this could be done until 2.2, so that's why this series is marked "for-2.2". I guess I'll have to keep a close look on qemu-devel whenever someone posts something resembling aio_set_fd_handler() for win32/win64. Max