[Qemu-devel] [PATCH] qom-test: blacklist xenigd

[Qemu-devel] [PATCH] qom-test: blacklist xenigd

[Michael S. Tsirkin]

Patch
    xen:hw:i386:pc_piix: introduce new machine for IGD passthrough
adds a new machine type.
Blacklist it since it forces xen accel.

Cc: Tiejun Chen <tiejun.chen@intel.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 tests/qom-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qom-test.c b/tests/qom-test.c
index 4246382..10799e2 100644
--- a/tests/qom-test.c
+++ b/tests/qom-test.c
@@ -16,7 +16,7 @@
 #include "qapi/qmp/types.h"
 
 static const char *blacklist_x86[] = {
-    "xenfv", "xenpv", NULL
+    "xenfv", "xenpv", "xenigd", NULL
 };
 
 static const struct {
-- 
MST

Re: [Qemu-devel] [PATCH] qom-test: blacklist xenigd

[Andreas Färber]

Am 14.08.2014 18:02, schrieb Michael S. Tsirkin:
> Patch
>     xen:hw:i386:pc_piix: introduce new machine for IGD passthrough
> adds a new machine type.
> Blacklist it since it forces xen accel.
> 
> Cc: Tiejun Chen <tiejun.chen@intel.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  tests/qom-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qom-test.c b/tests/qom-test.c
> index 4246382..10799e2 100644
> --- a/tests/qom-test.c
> +++ b/tests/qom-test.c
> @@ -16,7 +16,7 @@
>  #include "qapi/qmp/types.h"
>  
>  static const char *blacklist_x86[] = {
> -    "xenfv", "xenpv", NULL
> +    "xenfv", "xenpv", "xenigd", NULL
>  };
>  
>  static const struct {

Reviewed-by: Andreas Färber <afaerber@suse.de>

What's the status of that series? If it's not yet applied as I
understood your response, then you could just squash it there.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH] qom-test: blacklist xenigd

[Michael S. Tsirkin]

On Fri, Aug 15, 2014 at 06:33:10PM +0200, Andreas Färber wrote:
> Am 14.08.2014 18:02, schrieb Michael S. Tsirkin:
> > Patch
> >     xen:hw:i386:pc_piix: introduce new machine for IGD passthrough
> > adds a new machine type.
> > Blacklist it since it forces xen accel.
> > 
> > Cc: Tiejun Chen <tiejun.chen@intel.com>
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >  tests/qom-test.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/qom-test.c b/tests/qom-test.c
> > index 4246382..10799e2 100644
> > --- a/tests/qom-test.c
> > +++ b/tests/qom-test.c
> > @@ -16,7 +16,7 @@
> >  #include "qapi/qmp/types.h"
> >  
> >  static const char *blacklist_x86[] = {
> > -    "xenfv", "xenpv", NULL
> > +    "xenfv", "xenpv", "xenigd", NULL
> >  };
> >  
> >  static const struct {
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> 
> What's the status of that series? If it's not yet applied as I
> understood your response, then you could just squash it there.
> 
> Cheers,
> Andreas

I applied this in my tree.
To avoid breaking bisect, I made this this 1st patch
in the series.

> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg