From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XINaP-0004tZ-4A
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 15:55:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XINaG-00028T-3m
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 15:54:53 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53EE657C.7070604@twiddle.net>
Date: Fri, 15 Aug 2014 09:54:36 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1407785009-6538-1-git-send-email-tommusta@gmail.com>
	<1407785009-6538-3-git-send-email-tommusta@gmail.com>
In-Reply-To: <1407785009-6538-3-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/8] target-ppc: Bug Fix: rlwnm
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: agraf@suse.de

On 08/11/2014 09:23 AM, Tom Musta wrote:
> +#if defined(TARGET_PPC64)
> +        tcg_gen_andi_tl(t0, t0, MASK(32, 63));
> +#endif

Err. this is just simple zero-extension.

>          tcg_gen_mov_tl(cpu_gpr[rA(ctx->opcode)], t0);

Why not combine with the mov as

  tcg_gen_ext32u_tl

which will just expand to a mov for PPC32.


r~