From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XINnM-0008OO-Fm
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 16:08:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XINnF-0006GM-Ni
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 16:08:16 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53EE688D.2010307@twiddle.net>
Date: Fri, 15 Aug 2014 10:07:41 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1407785009-6538-1-git-send-email-tommusta@gmail.com>
	<1407785009-6538-5-git-send-email-tommusta@gmail.com>
In-Reply-To: <1407785009-6538-5-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/8] target-ppc: Bug Fix: mullw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: agraf@suse.de

On 08/11/2014 09:23 AM, Tom Musta wrote:
> For 64-bit implementations, the mullw result is the 64 bit product
> of the sign-extended least significant 32 bits of the source
> registers.
> 
> Fix the code to properly sign extend the source operands and produce
> a 64 bit product.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> ---
>  target-ppc/translate.c |   11 +++++++++++
>  1 files changed, 11 insertions(+), 0 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~