From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57658)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XIOEi-0002Qp-6B
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 16:36:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XIOEZ-00068e-00
	for qemu-devel@nongnu.org; Fri, 15 Aug 2014 16:36:32 -0400
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53EE6F3F.3050607@twiddle.net>
Date: Fri, 15 Aug 2014 10:36:15 -1000
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1407851110-8075-1-git-send-email-tommusta@gmail.com>
	<1407851110-8075-5-git-send-email-tommusta@gmail.com>
In-Reply-To: <1407851110-8075-5-git-send-email-tommusta@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [V2 PATCH 4/8] target-ppc: Bug Fix: mullw
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tom Musta <tommusta@gmail.com>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Cc: agraf@suse.de, david@gibson.dropbear.id.au

On 08/12/2014 03:45 AM, Tom Musta wrote:
> +#else
>      tcg_gen_mul_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rA(ctx->opcode)],
>                     cpu_gpr[rB(ctx->opcode)]);
>      tcg_gen_ext32s_tl(cpu_gpr[rD(ctx->opcode)], cpu_gpr[rD(ctx->opcode)]);
> +#endif

Note that the sign-extension can be dropped, since this is ifdef PPC32.
Perhaps even better to use tcg_gen_mul_i32 explicitly?  That at least
type-checks the arguments are all 32-bit as well.


r~