From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIwuH-0008HE-SU for qemu-devel@nongnu.org; Sun, 17 Aug 2014 05:37:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XIwuB-0002YP-NQ for qemu-devel@nongnu.org; Sun, 17 Aug 2014 05:37:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XIwuB-0002YJ-G4 for qemu-devel@nongnu.org; Sun, 17 Aug 2014 05:37:39 -0400 Message-ID: <53F077DC.5000603@redhat.com> Date: Sun, 17 Aug 2014 11:37:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1407843716-18301-1-git-send-email-marc.mari.barcelo@gmail.com> <1407843716-18301-8-git-send-email-marc.mari.barcelo@gmail.com> <20140813172740.GK27053@stefanha-thinkpad.redhat.com> <20140813235939.41a28781@crunchbang> In-Reply-To: <20140813235939.41a28781@crunchbang> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 07/11] libqos: Added basic virtqueue support to virtio implementation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYyBNYXLDrQ==?= , Stefan Hajnoczi Cc: qemu-devel@nongnu.org Il 13/08/2014 23:59, Marc Mar=C3=AD ha scritto: > If it is not dereferenced, it can work. But all references will have to > be casted from (void *) to (uint64_t) always which is what readl and > writel expect. I think this is better than calculating the addresses, > but is still a bit ugly. It would also break subtly on 32-bit builds if we ever try using addresses above the first 4G (which could be an interesting test, and doesn't require lots of host memory if one uses hotplug). Paolo