From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58950) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJNSV-00052j-Ni for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:58:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJNSP-00009D-Jq for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:58:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJNSP-00008g-BV for qemu-devel@nongnu.org; Mon, 18 Aug 2014 09:58:45 -0400 Message-ID: <53F20689.3000207@redhat.com> Date: Mon, 18 Aug 2014 15:58:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1408363934-28591-1-git-send-email-tangchen@cn.fujitsu.com> <20140818135602.GC28795@redhat.com> In-Reply-To: <20140818135602.GC28795@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] pc-dimm: Change PCDIMMDevice->node from UINT32 to INT32, and initialize it as -1. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Tang Chen Cc: peter.crosthwaite@xilinx.com, ehabkost@redhat.com, hutao@cn.fujitsu.com, qemu-devel@nongnu.org, isimatu.yasuaki@jp.fujitsu.com, imammedo@redhat.com Il 18/08/2014 15:56, Michael S. Tsirkin ha scritto: > > +/* Initialize PCDIMMDevice->node to -1 so that even if user doesn't specify > > + * any numa option, PCDIMMDevice->node won't be 0, which indicates node0. > > + * In this case, SRAT won't be created, and guest kernel will fake a node. > > + */ > > I think you simply mean > /* default value for PCDIMMDevice->node (unless specified by user) */ > > > +#define NO_NODE_ID -1 I think a comment about the SRAT would be useful. Paolo